Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed mpi_test to mpi_wait in forwardMessageSimple functions #117

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

jjepson2
Copy link

Here I changed the mpi_tests's to mpi_wait's, to prevent the send buffer from being overwritten until it has been sent out.

Copy link
Collaborator

@liuyangzhuan liuyangzhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't observe any significant slowdown in the triangular solve using this fix. But in case the code hangs in future, we can consider using separate buffers per tree.

@liuyangzhuan liuyangzhuan merged commit 980960e into xiaoyeli:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants