Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: on Windows, disable Qt6.7's dark mode and force Fusion style no matter what #1512

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented May 12, 2024

close #1506

We cannot do "follow the system" now because it conflicts with the existing qt style sheets.

"popup menu turns black", as shown in #1506 (comment), is unfixable as of Qt6.7.0

Also, all frames are lost in the new "ModernWindows" when the built-in dark mode is not enabled, but Windows's dark mode is enabled.

image

@shenlebantongying shenlebantongying force-pushed the fix/brain-dead-fusion-for-windows branch from 1d04348 to 750fe04 Compare May 12, 2024 22:10
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shenlebantongying shenlebantongying merged commit e7c5967 into xiaoyifang:staged May 13, 2024
13 checks passed
@shenlebantongying shenlebantongying deleted the fix/brain-dead-fusion-for-windows branch May 13, 2024 13:23
@shenlebantongying shenlebantongying changed the title fix: disable Qt6.7's dark mode and force Fusion style no matter what fix: on Windows, disable Qt6.7's dark mode and force Fusion style no matter what May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.7.0-GoldenDict.exe_windows-2019_20240505 interface settings do not enable dark mode and are invalid
1 participant