Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lingua Libre support #268

Merged
merged 9 commits into from
Dec 24, 2022
Merged

Add Lingua Libre support #268

merged 9 commits into from
Dec 24, 2022

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented Dec 22, 2022 •
edited
Loading

resolve #263

@shenlebantongying shenlebantongying deleted the feature/lingua_libre branch December 23, 2022 08:07
@shenlebantongying shenlebantongying restored the feature/lingua_libre branch December 23, 2022 08:08
@shenlebantongying shenlebantongying marked this pull request as ready for review December 24, 2022 04:35
@shenlebantongying
Copy link
Collaborator Author

shenlebantongying commented Dec 24, 2022 •
edited
Loading

This PR is ready. @xiaoyifang

The "languageCode" requires the user to take a trip to lingualibre's website because

  • Not every language has large number of recordings, users have to know the number

Result:

image

New staff added to config file

<lingua>
  <enable>1</enable>
  <languageCodes>eng</languageCodes>
</lingua>

Sadly, Wikipedia is blocked in china, thus users have to know how to use better internet.

@xiaoyifang xiaoyifang merged commit 6fc3684 into xiaoyifang:staged Dec 24, 2022
@shenlebantongying shenlebantongying deleted the feature/lingua_libre branch April 5, 2023 16:14
@shenlebantongying shenlebantongying mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] First class Lingua Libre support
2 participants
@shenlebantongying @xiaoyifang