Let the user disable main window stealing focus when searching. #387

tatsumoto-ren · 2023-03-13T18:36:46Z

When a search is triggered, the main window focuses itself even if it's already visible, which may be undesirable for some users. Let the user disable this behavior.

xiaoyifang · 2023-03-14T01:20:25Z

mainwindow.cc

 if ( !isActiveWindow() )
 {
 qApp->setActiveWindow( this );
- raise();
- activateWindow();
+ if (cfg.preferences.raiseMainWindow) {
+ raise();
+ activateWindow();
+ }
 shown = true;
 }


when a search action is triggered, does the mainwindow can be inactive at the same time?

It can be visible but inactive, which I assume is what the isActiveWindow() call for.

there may be case when gd windows has invisible .at this case ,raise() should be called but without activateWindow()

does raise() need to put outside of the if condition

at this case ,raise() should be called but without activateWindow()

I'm going to test this.

No, apparently you have to disable raise() as well to prevent the main window from focusing itself.

https://github.com/xiaoyifang/goldendict/blob/31c72dacdc5943ccbd4078578f4663d332c8dc52/mainwindow.cc#L2916-L2923

I think when mainwindow is invisible ,the application has choosen this branch.

does popup dialog need to change accordingly?

does popup dialog need to change accordingly?

I think so.

If the window is actually invisible, it is fine to raise it.

xiaoyifang · 2023-03-14T01:22:56Z

please add some more informations about this PR
What's the consenquence without this PR and what's the benefit?

tatsumoto-ren · 2023-03-15T09:06:59Z

please add some more informations about this PR
What's the consequence without this PR and what's the benefit?

For example, when I watch a video in MPV with Mpvacious, I have it automatically send the subtitles to GoldenDict. Every time a new subtitle appears on the screen, GoldenDict focuses itself, which is not always desirable. I only want to focus it myself when I need to. Without this PR I can only do it by having GoldenDict and MPV open in separate workspaces.

A screencast: https://invidious.baczek.me/watch?v=bvl-dtB0wLs

xiaoyifang · 2023-03-15T14:52:43Z

this should also be changed. when scanpopup is pinned and set at the top

https://github.com/xiaoyifang/goldendict/blob/31c72dacdc5943ccbd4078578f4663d332c8dc52/scanpopup.cc#L583-L597

tatsumoto-ren · 2023-03-15T17:47:40Z

With the last commit popups work as intended.

xiaoyifang · 2023-03-16T01:08:25Z

I think raiseWindowOnSearch should be called unraiseWindowOnSearch(or some other variable like this, the description of label should also be changed accordingly.

The reason is :
users mainwindow will be focused after search ,this should be the default behaviour.

after upgrade, users mainwindow will lost focus(as the checked box has been unchecked(I think) in the configuration file.
it will cause confusion to the current users.

xiaoyifang · 2023-03-16T01:09:50Z

scanpopup.cc

@@ -580,7 +580,7 @@ void ScanPopup::engagePopup( bool forcePopup, bool giveFocus )
 //QApplication::processEvents(); // Make window appear immediately no matter what
 }
 else
- if ( ui.pinButton->isChecked() )
+ if ( ui.pinButton->isChecked() && cfg.preferences.raiseMainWindow)
 {
 // Pinned-down window isn't always on top, so we need to raise it
 show();


show() should this method be called at all conditions?

show() should this method be called at all conditions?

I think so. I will change that.

tatsumoto-ren · 2023-03-16T19:53:24Z

I think raiseWindowOnSearch should be called unraiseWindowOnSearch(or some other variable like this, the description of label should also be changed accordingly.
The reason is :
users mainwindow will be focused after search ,this should be the default behaviour.
after upgrade, users mainwindow will lost focus(as the checked box has been unchecked(I think) in the configuration file.
it will cause confusion to the current users.

I think if the setting is on by default, which is the current behavior, then after updating the app the users won't notice any change unless they uncheck the setting. Correct me if I'm wrong.

We could call the setting dontRaiseWindowOnSearch, but then all the if blocks will have to be negated, which doesn't look pretty in the source code.

xiaoyifang · 2023-03-17T01:00:16Z

I think if the setting is on by default, which is the current behavior, then after updating the app the users won't notice any change unless they uncheck the setting. Correct me if I'm wrong.

ok,Let's use your way

last thing:
the changed codes need to follow the .clang-format guideline .
check this https://github.com/xiaoyifang/goldendict/blob/staged/howto/how%20to%20use%20.clang-format%20to%20format%20the%20code.md

…ed when search is triggered

tatsumoto-ren · 2023-03-17T01:19:11Z

If I run clang-format on the 6 files I've changed, the diff is going to be huge, but I'll try.

xiaoyifang · 2023-03-17T01:21:27Z

If I run clang-format on the 6 files I've changed, the diff is going to be huge, but I'll try.

only on the changed lines.

after set the clang format ,you can select the changes lines and use menu Edit->'Advanced'->format the selected lines

If you have difficult doing this ,Let's just pass the step , your current code format is also good enough.

tatsumoto-ren · 2023-03-17T01:21:55Z

Alright.

xiaoyifang · 2023-03-17T01:23:44Z

7f9edee this commit should be revert or reset .

too much unrelated line format changes will make future bug tracking difficult.

xiaoyifang · 2023-03-17T01:43:16Z

config.cc

+ newTabsOpenAfterCurrentOne( false ),
+ newTabsOpenInBackground( true ),
+ hideSingleTab( false ),
+ mruTabOrder( false ),
+ hideMenubar( false ),
+ enableTrayIcon( true ),
+ startToTray( false ),
+ closeToTray( true ),
+ autoStart( false ),
+ doubleClickTranslates( true ),
+ selectWordBySingleClick( false ),
+ autoScrollToTargetArticle( true ),
+ escKeyHidesMainWindow( false ),
+ darkMode( false ),
+ darkReaderMode( false ),
+ alwaysOnTop( false ),
+ searchInDock( false ),
+
+ enableMainWindowHotkey( true ),
+ mainWindowHotkey( QKeySequence( "Ctrl+F11,F11" ) ),
+ enableClipboardHotkey( true ),
+ clipboardHotkey( QKeySequence( "Ctrl+C,C" ) ),
+
+ startWithScanPopupOn( false ),
+ enableScanPopupModifiers( false ),
+ scanPopupModifiers( 0 ),
+ ignoreOwnClipboardChanges( false ),
+ scanToMainWindow( false ),
+ ignoreDiacritics( false ),
+ ignorePunctuation( false ),
 #ifdef HAVE_X11
- // Enable both Clipboard and Selection by default so that X users can enjoy full
- // power and disable optionally.
- trackClipboardScan ( true ),
- trackSelectionScan ( true ),
- showScanFlag( false ),
+ // Enable both Clipboard and Selection by default so that X users can enjoy full
+ // power and disable optionally.
+ trackClipboardScan( true ),
+ trackSelectionScan( true ),
+ showScanFlag( false ),
 #endif
- pronounceOnLoadMain( false ),
- pronounceOnLoadPopup( false ),
- useInternalPlayer( InternalPlayerBackend::anyAvailable() ),
- internalPlayerBackend( InternalPlayerBackend::defaultBackend() ),
- checkForNewReleases( true ),
- disallowContentFromOtherSites( false ),
- enableWebPlugins( false ),
- hideGoldenDictHeader( false ),
- maxNetworkCacheSize( 50 ),
- clearNetworkCacheOnExit( true ),
- zoomFactor( 1 ),
- helpZoomFactor( 1 ),
- wordsZoomLevel( 0 ),
- maxStringsInHistory( 500 ),
- storeHistory( 1 ),
- alwaysExpandOptionalParts( false )
-, historyStoreInterval( 0 )
-, favoritesStoreInterval( 0 )
-, confirmFavoritesDeletion( true )
-, collapseBigArticles( false )
-, articleSizeLimit( 2000 )
-, limitInputPhraseLength( false )
-, inputPhraseLengthLimit( 1000 )
-, maxDictionaryRefsInContextMenu ( 20 )
-, synonymSearchEnabled( true ),
- stripClipboard( false ),
- raiseWindowOnSearch(true)
+ pronounceOnLoadMain( false ),
+ pronounceOnLoadPopup( false ),
+ useInternalPlayer( InternalPlayerBackend::anyAvailable() ),
+ internalPlayerBackend( InternalPlayerBackend::defaultBackend() ),
+ checkForNewReleases( true ),
+ disallowContentFromOtherSites( false ),
+ enableWebPlugins( false ),
+ hideGoldenDictHeader( false ),
+ maxNetworkCacheSize( 50 ),
+ clearNetworkCacheOnExit( true ),
+ zoomFactor( 1 ),
+ helpZoomFactor( 1 ),
+ wordsZoomLevel( 0 ),
+ maxStringsInHistory( 500 ),
+ storeHistory( 1 ),
+ alwaysExpandOptionalParts( false ),


do not change these lines, seems the .clang-format settings has improper configuration .I'll check this file.

the original code is usually indent two spaces

xiaoyifang · 2023-03-17T01:54:37Z

76fa9a8
further code format should be ok now.

sonarcloud · 2023-03-17T02:10:14Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

xiaoyifang reviewed Mar 14, 2023

View reviewed changes

xiaoyifang reviewed Mar 16, 2023

View reviewed changes

add a checkbox that allows the user to disable main window being rais…

10ee8e0

…ed when search is triggered

run clang-format on the edited lines

5201279

xiaoyifang reviewed Mar 17, 2023

View reviewed changes

partially revert clang-format

187563d

xiaoyifang merged commit fb6d4f9 into xiaoyifang:staged Mar 17, 2023

tatsumoto-ren deleted the raise-checkbox branch March 17, 2023 01:58

xiaoyifang mentioned this pull request Apr 30, 2023

List issues fixed in this repo while not in official repo #587

Open

shenlebantongying mentioned this pull request Oct 1, 2024

Disable focus stealing on new search on windows doesn't work. #1795

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Let the user disable main window stealing focus when searching. #387

Let the user disable main window stealing focus when searching. #387

tatsumoto-ren commented Mar 13, 2023

xiaoyifang Mar 14, 2023

tatsumoto-ren Mar 15, 2023 •

edited

Loading

xiaoyifang Mar 15, 2023 •

edited

Loading

tatsumoto-ren Mar 15, 2023

tatsumoto-ren Mar 15, 2023

xiaoyifang Mar 15, 2023 •

edited

Loading

xiaoyifang Mar 15, 2023

tatsumoto-ren Mar 15, 2023

tatsumoto-ren Mar 15, 2023

xiaoyifang commented Mar 14, 2023 •

edited

Loading

tatsumoto-ren commented Mar 15, 2023

xiaoyifang commented Mar 15, 2023 •

edited

Loading

tatsumoto-ren commented Mar 15, 2023

xiaoyifang commented Mar 16, 2023 •

edited

Loading

xiaoyifang Mar 16, 2023 •

edited

Loading

tatsumoto-ren Mar 16, 2023

tatsumoto-ren commented Mar 16, 2023 •

edited

Loading

xiaoyifang commented Mar 17, 2023

tatsumoto-ren commented Mar 17, 2023

xiaoyifang commented Mar 17, 2023 •

edited

Loading

tatsumoto-ren commented Mar 17, 2023

xiaoyifang commented Mar 17, 2023 •

edited

Loading

xiaoyifang Mar 17, 2023 •

edited

Loading

tatsumoto-ren Mar 17, 2023

xiaoyifang commented Mar 17, 2023

sonarcloud bot commented Mar 17, 2023

Let the user disable main window stealing focus when searching. #387

Let the user disable main window stealing focus when searching. #387

Conversation

tatsumoto-ren commented Mar 13, 2023

Choose a reason for hiding this comment

tatsumoto-ren Mar 15, 2023 • edited Loading

Choose a reason for hiding this comment

xiaoyifang Mar 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiaoyifang Mar 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiaoyifang commented Mar 14, 2023 • edited Loading

tatsumoto-ren commented Mar 15, 2023

xiaoyifang commented Mar 15, 2023 • edited Loading

tatsumoto-ren commented Mar 15, 2023

xiaoyifang commented Mar 16, 2023 • edited Loading

xiaoyifang Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tatsumoto-ren commented Mar 16, 2023 • edited Loading

xiaoyifang commented Mar 17, 2023

tatsumoto-ren commented Mar 17, 2023

xiaoyifang commented Mar 17, 2023 • edited Loading

tatsumoto-ren commented Mar 17, 2023

xiaoyifang commented Mar 17, 2023 • edited Loading

xiaoyifang Mar 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiaoyifang commented Mar 17, 2023

sonarcloud bot commented Mar 17, 2023

tatsumoto-ren Mar 15, 2023 •

edited

Loading

xiaoyifang Mar 15, 2023 •

edited

Loading

xiaoyifang Mar 15, 2023 •

edited

Loading

xiaoyifang commented Mar 14, 2023 •

edited

Loading

xiaoyifang commented Mar 15, 2023 •

edited

Loading

xiaoyifang commented Mar 16, 2023 •

edited

Loading

xiaoyifang Mar 16, 2023 •

edited

Loading

tatsumoto-ren commented Mar 16, 2023 •

edited

Loading

xiaoyifang commented Mar 17, 2023 •

edited

Loading

xiaoyifang commented Mar 17, 2023 •

edited

Loading

xiaoyifang Mar 17, 2023 •

edited

Loading