-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: add group by metadata #613
Conversation
01ee26c
to
6b0eada
Compare
If we implement more features on The format will be locked unless we want to break someone and got hated. If it ever got expanded, we will reinvent a config format. This will happen because renaming will also likely be implemented here. Maybe we should consider using existing human-oriented formats like toml https://toml.io/ so that we don't need to maintain/write related parsing code? Of course, it is not hard, but like the custom command line parser, there are details like report errors on typos / write-to-config that requires unnecessary work. Also, we don't need to describe the syntax, just link to https://toml.io/ But, so far I can only think about 4 possible fields in future 😅
|
are there some c++ library which can use to parse the toml format ? |
How about this: https://github.com/marzer/tomlplusplus We just need to include a single file into the source tree https://github.com/marzer/tomlplusplus/blob/master/toml.hpp or
|
Great, I'll see what I can do . |
6b0eada
to
4ad6cf2
Compare
I'm really not comfortable/familiar with this modern syntax of tomlplus 😿 |
You seems forget to add the submodule, |
6b72655
to
99c5e3b
Compare
btw, toml++ includes 3 formatters (toml, yml & json:sweat_smile: ), if we don't need them we can
|
99c5e3b
to
3f19632
Compare
the author said that this will not effect performance and size. |
10ef5fd
to
a353fbf
Compare
I tested with some invalid inputs, and the code works OK to me :D |
a353fbf
to
9579f37
Compare
9579f37
to
1f20e1d
Compare
SonarCloud Quality Gate failed. 4 Bugs |
close #612