forked from apache/ozone
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HDDS-9959. Propagate group remove to other datanodes during pipeline …
…close (apache#5827)
- Loading branch information
Showing
5 changed files
with
201 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
...p/ozone/container/common/statemachine/commandhandler/TestClosePipelineCommandHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with this | ||
| * work for additional information regarding copyright ownership. The ASF | ||
| * licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.container.common.statemachine.commandhandler; | ||
|
|
||
| import com.google.common.util.concurrent.MoreExecutors; | ||
| import org.apache.hadoop.hdds.conf.OzoneConfiguration; | ||
| import org.apache.hadoop.hdds.protocol.DatanodeDetails; | ||
| import org.apache.hadoop.hdds.protocol.MockDatanodeDetails; | ||
| import org.apache.hadoop.hdds.ratis.RatisHelper; | ||
| import org.apache.hadoop.hdds.scm.pipeline.PipelineID; | ||
| import org.apache.hadoop.ozone.container.common.ContainerTestUtils; | ||
| import org.apache.hadoop.ozone.container.common.statemachine.SCMConnectionManager; | ||
| import org.apache.hadoop.ozone.container.common.statemachine.StateContext; | ||
| import org.apache.hadoop.ozone.container.common.transport.server.ratis.XceiverServerRatis; | ||
| import org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer; | ||
| import org.apache.hadoop.ozone.protocol.commands.ClosePipelineCommand; | ||
| import org.apache.hadoop.ozone.protocol.commands.SCMCommand; | ||
| import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ClosePipelineCommandProto; | ||
| import org.apache.ratis.client.RaftClient; | ||
| import org.apache.ratis.client.api.GroupManagementApi; | ||
| import org.apache.ratis.protocol.RaftPeer; | ||
| import org.apache.ratis.protocol.RaftPeerId; | ||
| import org.apache.ratis.server.RaftServer; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyBoolean; | ||
| import static org.mockito.ArgumentMatchers.eq; | ||
| import static org.mockito.Mockito.lenient; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| /** | ||
| * Test cases to verify ClosePipelineCommandHandler. | ||
| */ | ||
| public class TestClosePipelineCommandHandler { | ||
|
|
||
| private OzoneContainer ozoneContainer; | ||
| private StateContext stateContext; | ||
| private SCMConnectionManager connectionManager; | ||
| private RaftClient raftClient; | ||
| private GroupManagementApi raftClientGroupManager; | ||
| private OzoneConfiguration conf; | ||
|
|
||
| @BeforeEach | ||
| public void setup() throws Exception { | ||
| conf = new OzoneConfiguration(); | ||
| ozoneContainer = mock(OzoneContainer.class); | ||
| connectionManager = mock(SCMConnectionManager.class); | ||
| raftClient = mock(RaftClient.class); | ||
| raftClientGroupManager = mock(GroupManagementApi.class); | ||
| lenient().when(raftClient.getGroupManagementApi( | ||
| any(RaftPeerId.class))).thenReturn(raftClientGroupManager); | ||
| } | ||
|
|
||
| @Test | ||
| void testPipelineClose() throws IOException { | ||
| final List<DatanodeDetails> datanodes = getDatanodes(); | ||
| final DatanodeDetails currentDatanode = datanodes.get(0); | ||
| final PipelineID pipelineID = PipelineID.randomId(); | ||
| final SCMCommand<ClosePipelineCommandProto> command = | ||
| new ClosePipelineCommand(pipelineID); | ||
| stateContext = ContainerTestUtils.getMockContext(currentDatanode, conf); | ||
|
|
||
| final boolean shouldDeleteRatisLogDirectory = true; | ||
| XceiverServerRatis writeChannel = mock(XceiverServerRatis.class); | ||
| when(ozoneContainer.getWriteChannel()).thenReturn(writeChannel); | ||
| when(writeChannel.getShouldDeleteRatisLogDirectory()).thenReturn(shouldDeleteRatisLogDirectory); | ||
| when(writeChannel.isExist(pipelineID.getProtobuf())).thenReturn(true); | ||
| Collection<RaftPeer> raftPeers = datanodes.stream() | ||
| .map(RatisHelper::toRaftPeer) | ||
| .collect(Collectors.toList()); | ||
| when(writeChannel.getServer()).thenReturn(mock(RaftServer.class)); | ||
| when(writeChannel.getServer().getId()).thenReturn(RatisHelper.toRaftPeerId(currentDatanode)); | ||
| when(writeChannel.getRaftPeersInPipeline(pipelineID)).thenReturn(raftPeers); | ||
|
|
||
| final ClosePipelineCommandHandler commandHandler = | ||
| new ClosePipelineCommandHandler((leader, tls) -> raftClient, MoreExecutors.directExecutor()); | ||
| commandHandler.handle(command, ozoneContainer, stateContext, connectionManager); | ||
|
|
||
| verify(writeChannel, times(1)) | ||
| .removeGroup(pipelineID.getProtobuf()); | ||
|
|
||
| verify(raftClientGroupManager, times(2)) | ||
| .remove(any(), eq(shouldDeleteRatisLogDirectory), eq(!shouldDeleteRatisLogDirectory)); | ||
| } | ||
|
|
||
| @Test | ||
| void testCommandIdempotency() throws IOException { | ||
| final List<DatanodeDetails> datanodes = getDatanodes(); | ||
| final DatanodeDetails currentDatanode = datanodes.get(0); | ||
| final PipelineID pipelineID = PipelineID.randomId(); | ||
| final SCMCommand<ClosePipelineCommandProto> command = | ||
| new ClosePipelineCommand(pipelineID); | ||
| stateContext = ContainerTestUtils.getMockContext(currentDatanode, conf); | ||
|
|
||
| XceiverServerRatis writeChannel = mock(XceiverServerRatis.class); | ||
| when(ozoneContainer.getWriteChannel()).thenReturn(writeChannel); | ||
| // When the pipeline has been closed earlier by other datanode that received a close pipeline command | ||
| when(writeChannel.isExist(pipelineID.getProtobuf())).thenReturn(false); | ||
|
|
||
| final ClosePipelineCommandHandler commandHandler = | ||
| new ClosePipelineCommandHandler(conf, MoreExecutors.directExecutor()); | ||
| commandHandler.handle(command, ozoneContainer, stateContext, connectionManager); | ||
|
|
||
| verify(writeChannel, times(0)) | ||
| .removeGroup(pipelineID.getProtobuf()); | ||
|
|
||
| verify(raftClientGroupManager, times(0)) | ||
| .remove(any(), anyBoolean(), anyBoolean()); | ||
| } | ||
|
|
||
| private List<DatanodeDetails> getDatanodes() { | ||
| final DatanodeDetails dnOne = MockDatanodeDetails.randomDatanodeDetails(); | ||
| final DatanodeDetails dnTwo = MockDatanodeDetails.randomDatanodeDetails(); | ||
| final DatanodeDetails dnThree = MockDatanodeDetails.randomDatanodeDetails(); | ||
| return Arrays.asList(dnOne, dnTwo, dnThree); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters