Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in mod keys #2

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Conversation

Acidham
Copy link
Contributor

@Acidham Acidham commented Nov 24, 2019

The workflow was not able to open the web browser. I found some inconsistencies in mod keys where the text was arg value instead of the URL.

@xilopaint
Copy link
Owner

Looks good. Could you keep cmd mod key for the Copy to Clipboard action? In your implementation people may not notice that actioning the item is enough to do the job.

@Acidham
Copy link
Contributor Author

Acidham commented Nov 24, 2019

I was not sure because arg was set to text instead of URL and this caused the error. The only valid default action would be copy to clipboard and the other two mods seems to be the Browser action. Or do I miss something?

@xilopaint
Copy link
Owner

I was not sure because arg was set to text instead of URL and this caused the error.

It's likely a mistake I committed when adapted the original workflow. Your PR is good in fixing it.

The only valid default action would be copy to clipboard and the other two mods seems to be the Browser action.

I prefer not using a default action since the subtitle does not inform the user that actioning the item will copy the text to clipboard. So I prefer to use cmd to Copy to Clipboard, alt to Open Apple Specifications Site for This Hardware and ctrl to Open Apple Support Site for This Hardware.

Could you make these changes in your PR so I can merge it?

@Acidham
Copy link
Contributor Author

Acidham commented Nov 24, 2019

Sure can do but tell me what should happen when pressing enter? Nothing? If yes I could implement valid:false
Let me know an I will add

@xilopaint
Copy link
Owner

xilopaint commented Nov 24, 2019

Sure can do but tell me what should happen when pressing enter? Nothing? If yes I could implement valid:false
Let me know an I will add

Well, my take on this may be not so "alfredish" but I don't particularly like valid:false as I can't dismiss the Alfred bar by actioning the return key even if it does nothing, which is the case here.

@xilopaint xilopaint merged commit b7b7aad into xilopaint:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants