qt: Improve ComponentBox #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aleixpol
commented
Oct 4, 2023
aleixpol
commented
- Adds iterators so that we don't need to create a full QList every time that we get a result. We can iterate it little by little and only keep in memory what we need.
- Adds operator+= and erase() so the ComponentBox can be operated on.
|
Discover's counterpart: https://invent.kde.org/plasma/discover/-/merge_requests/650 |
ximion
requested changes
Oct 5, 2023
aleixpol
force-pushed
the
work/apol/operate-componentbox
branch
3 times, most recently
from
37d7bf1 to
1fbefa3
Compare
ximion
reviewed
Oct 5, 2023
aleixpol
force-pushed
the
work/apol/operate-componentbox
branch
2 times, most recently
from
e910032 to
fbd1895
Compare
|
Can you rebase and use the existing new |
|
Ping ;-) |
Allows us to not create all the Component objects at once with toList.
aleixpol
force-pushed
the
work/apol/operate-componentbox
branch
from
fbd1895 to
ffde808
Compare
ximion
requested changes
Oct 18, 2023
aleixpol
force-pushed
the
work/apol/operate-componentbox
branch
from
ffde808 to
b86be27
Compare
|
This looks good now, thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.