fix: reference the current version, not latest #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the latest version of hops dropped node js support in the engines field. this test runs also on 14.x and 13.x branches, which still have node 12 and 15 in their test matrix. if they refer to latest, instead of their own version the test fails as hosp 15 does not support those node versions any more.
robertkowalski
added
📦 master
|
bors ping |
|
pong |
jhiode
previously approved these changes
Oct 1, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2021
1983: fix: reference the current version, not latest r=robertkowalski a=robertkowalski the latest version of hops dropped node js support in the engines field. this test runs also on 14.x and 13.x branches, which still have node 12 and 15 in their test matrix. if they refer to latest, instead of their own version the test fails as hosp 15 does not support those node versions any more. This pull request closes issue # (_put the issue number here_) <!-- This is a template. Feel free to remove the parts you do not need! Start with this line, for example --> ## Current state <!-- explanation of the current state --> ## Changes introduced here <!-- explanation of the changes you did in this pull request --> ## Checklist - [ ] All commit messages adhere to the [appropriate format](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit) in order to trigger a correct release - [ ] All code is written in untranspiled ECMAScript (ES 2017) and is formatted using [prettier](https://prettier.io) - [ ] Necessary unit tests are added in order to ensure correct behavior - [ ] Documentation has been added <details> <summary>Bors merge bot cheat sheet</summary> We are using [bors-ng](https://github.com/bors-ng/bors-ng) to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of `bors delegate+` or `bors delegate=[list]`). | Syntax | Description | | --- | --- | | bors merge | Run the test suite and push to master if it passes. Short for "reviewed: looks good." | | bors merge- | Cancel an r+, r=, merge, or merge= | | bors try | Run the test suite without pushing to master. | | bors try- | Cancel a try | | bors delegate+ | Allow the pull request author to merge their changes. | | bors delegate=[list] | Allow the listed users to r+ this pull request's changes. | | bors retry | Run the previous command a second time. | This is a short collection of opinionated commands. For a full list of the commands read the [bors reference](https://bors.tech/documentation/). </details> Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
|
Canceled. |
|
bors merge- |
jhiode
approved these changes
Oct 1, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2021
1983: fix: reference the current version, not latest r=robertkowalski a=robertkowalski the latest version of hops dropped node js support in the engines field. this test runs also on 14.x and 13.x branches, which still have node 12 and 15 in their test matrix. if they refer to latest, instead of their own version the test fails as hosp 15 does not support those node versions any more. This pull request closes issue # (_put the issue number here_) <!-- This is a template. Feel free to remove the parts you do not need! Start with this line, for example --> ## Current state <!-- explanation of the current state --> ## Changes introduced here <!-- explanation of the changes you did in this pull request --> ## Checklist - [ ] All commit messages adhere to the [appropriate format](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit) in order to trigger a correct release - [ ] All code is written in untranspiled ECMAScript (ES 2017) and is formatted using [prettier](https://prettier.io) - [ ] Necessary unit tests are added in order to ensure correct behavior - [ ] Documentation has been added <details> <summary>Bors merge bot cheat sheet</summary> We are using [bors-ng](https://github.com/bors-ng/bors-ng) to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of `bors delegate+` or `bors delegate=[list]`). | Syntax | Description | | --- | --- | | bors merge | Run the test suite and push to master if it passes. Short for "reviewed: looks good." | | bors merge- | Cancel an r+, r=, merge, or merge= | | bors try | Run the test suite without pushing to master. | | bors try- | Cancel a try | | bors delegate+ | Allow the pull request author to merge their changes. | | bors delegate=[list] | Allow the listed users to r+ this pull request's changes. | | bors retry | Run the previous command a second time. | This is a short collection of opinionated commands. For a full list of the commands read the [bors reference](https://bors.tech/documentation/). </details> Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
|
Timed out. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
1983: fix: reference the current version, not latest r=robertkowalski a=robertkowalski the latest version of hops dropped node js support in the engines field. this test runs also on 14.x and 13.x branches, which still have node 12 and 15 in their test matrix. if they refer to latest, instead of their own version the test fails as hosp 15 does not support those node versions any more. This pull request closes issue # (_put the issue number here_) <!-- This is a template. Feel free to remove the parts you do not need! Start with this line, for example --> ## Current state <!-- explanation of the current state --> ## Changes introduced here <!-- explanation of the changes you did in this pull request --> ## Checklist - [ ] All commit messages adhere to the [appropriate format](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit) in order to trigger a correct release - [ ] All code is written in untranspiled ECMAScript (ES 2017) and is formatted using [prettier](https://prettier.io) - [ ] Necessary unit tests are added in order to ensure correct behavior - [ ] Documentation has been added <details> <summary>Bors merge bot cheat sheet</summary> We are using [bors-ng](https://github.com/bors-ng/bors-ng) to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of `bors delegate+` or `bors delegate=[list]`). | Syntax | Description | | --- | --- | | bors merge | Run the test suite and push to master if it passes. Short for "reviewed: looks good." | | bors merge- | Cancel an r+, r=, merge, or merge= | | bors try | Run the test suite without pushing to master. | | bors try- | Cancel a try | | bors delegate+ | Allow the pull request author to merge their changes. | | bors delegate=[list] | Allow the listed users to r+ this pull request's changes. | | bors retry | Run the previous command a second time. | This is a short collection of opinionated commands. For a full list of the commands read the [bors reference](https://bors.tech/documentation/). </details> Co-authored-by: Robert Kowalski <robert.kowalski@new-work.se>
robertkowalski
removed
the
📦 v14
|
bors cancel |
|
Canceled. |
|
bors merge |
|
bors cancel |
|
Canceled. |
|
bors merge |
|
Build succeeded:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the latest version of hops dropped node js support in the engines
field.
this test runs also on 14.x and 13.x branches, which still have
node 12 and 15 in their test matrix. if they refer to latest,
instead of their own version the test fails as hosp 15 does not
support those node versions any more.
This pull request closes issue # (put the issue number here)
Current state
Changes introduced here
Checklist
Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of
bors delegate+orbors delegate=[list]).This is a short collection of opinionated commands. For a full list of the commands read the bors reference.