Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): externalize server source-map to prevent RangeError #2023

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

ZauberNerd
Copy link
Contributor

For some reason we see intermittent failures with the source-map-support
package (examples: evanw/node-source-map-support#252
and evanw/node-source-map-support#93).
The fix that worked for us seems to be to externalize the source-map.

Bors merge bot cheat sheet

We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax Description
bors merge Run the test suite and push to master if it passes. Short for "reviewed: looks good."
bors merge- Cancel an r+, r=, merge, or merge=
bors try Run the test suite without pushing to master.
bors try- Cancel a try
bors delegate+ Allow the pull request author to merge their changes.
bors delegate=[list] Allow the listed users to r+ this pull request's changes.
bors retry Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

For some reason we see intermittent failures with the source-map-support
package (examples: evanw/node-source-map-support#252
and evanw/node-source-map-support#93).
The fix that worked for us seems to be to externalize the source-map.

Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
@ZauberNerd ZauberNerd added 📦 master Apply this label to a pull request, if it has to be cherry-picked to the maste-branch. 📦 v14 Apply this label to a pull request, if it has to be cherry-picked to the v14.x-branch after merging. 📦 v15 Apply this label to a pull request, if it has to be cherry-picked to the v15.x-branch after merging. labels Jan 12, 2022
@ZauberNerd ZauberNerd merged commit 79e4290 into master Jan 12, 2022
@ZauberNerd ZauberNerd deleted the fix-rangeerror branch January 12, 2022 08:58
This was referenced Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 master Apply this label to a pull request, if it has to be cherry-picked to the maste-branch. 📦 v14 Apply this label to a pull request, if it has to be cherry-picked to the v14.x-branch after merging. 📦 v15 Apply this label to a pull request, if it has to be cherry-picked to the v15.x-branch after merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants