Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve renovate config #896

Merged
merged 4 commits into from
Jun 19, 2019
Merged

Improve renovate config #896

merged 4 commits into from
Jun 19, 2019

Conversation

ZauberNerd
Copy link
Contributor

Pimp our renovate config with more specific rules:

  • add "untool" as package to the untool monorepo group filter
  • peerDependencies should be "widened (ie: "react": "15 || 16" instead of upgrading to 16)
  • devDependencies should be bumped (ie: an update from prettier@^1.0.0 to prettier@1.1.0 which would normally fall under our version range, should be updated to the new range: "prettier": "^1.1.0")
  • devDependencies in the root package.json should be auto merged if they are a minor or patch upgrade

@ZauberNerd ZauberNerd requested review from dmbch and jhiode June 11, 2019 14:29
@ZauberNerd ZauberNerd force-pushed the improve-renovate-config branch 3 times, most recently from f2a4747 to 10bdcc1 Compare June 12, 2019 08:31
Copy link
Contributor

@dmbch dmbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not restrict renovate to non-office hours any more? This might prevent some conflicts, does it not?

renovate.json Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
Copy link
Contributor

@dmbch dmbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automerging is not going to work: renovatebot/renovate#846

@ZauberNerd
Copy link
Contributor Author

Automerging is not going to work: renovatebot/renovate#846

😢

Why not restrict renovate to non-office hours any more? This might prevent some conflicts, does it not?

What kind of conflicts are you talking about? I initially enabled this option, to preserve our travis-ci resources, but disabled it now, because there aren't too many PRs being opened anyways (I think renovate already restricts this to max every 2 hours).

@ZauberNerd ZauberNerd force-pushed the improve-renovate-config branch 2 times, most recently from 5f3065a to e6fdece Compare June 12, 2019 14:43
@ZauberNerd ZauberNerd requested a review from dmbch June 12, 2019 15:26
@ZauberNerd ZauberNerd merged commit 497aa02 into master Jun 19, 2019
@ZauberNerd ZauberNerd deleted the improve-renovate-config branch June 19, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants