add an early return to not connect to the servers #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to write or delete
| end | ||
| end.each(&:join) | ||
| end.each(&:join) | ||
| end |
There was a problem hiding this comment.
Thanks for the PR!
Instead of wrapping the code in a huge unless block, I would prefer to just use an early return in the first line of the method:
return if @queued_for_write.empty?There was a problem hiding this comment.
Ah, I now see that you still want to call after_flush_writes. Then the suggestion I just made obviously does not work.
|
Yep, exactly! I wanted to keep the So should I use an early return in |
boosty
added a commit
that referenced
this pull request
Mar 31, 2015
…ing_the_servers add an early return to not connect to the servers
|
I think keeping the code consistent is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if there is nothing to write or delete
This is needed, because if the model doesn't have an image, we still rely on the asset servers.