Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel mapping 255 and Ambisonics mapping 2 and 3 #45

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

chris-hld
Copy link

Ambisonics is currently not available in opusfile.
This PR is aiming to start implementing the remaining mappings for Opus and its tools.

@chris-hld
Copy link
Author

The current state should enable encoding and decoding of Ambix / Higher-order ambisonics with the standard opus tools.
Any reviews or suggestions are very welcome.

@chris-hld chris-hld changed the title Channel ambisonics mapping 2 and 3 Channel mapping 255 and Ambisonics mapping 2 and 3 Dec 14, 2023
@olilarkin
Copy link

Nice!

@olilarkin
Copy link

@chris-hld I am not a maintainer of opusfile, but I imagine the maintainers might like a cleaner commit history on this PR in order to consider it. I am happy to help test this

@chris-hld
Copy link
Author

I took care of a last warning and completed the cleanup and documentation / commenting.
Everything related to mapping 3 should now also be guarded by OPUS_HAVE_OPUS_PROJECTION_H.
I am using and testing the modes of this PR daily and at least for me it's all working as expected.

Regarding the commit history, I completely agree. Feel free to squash on merge! If needed I can also rework the history and make it more compact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants