Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2212 #2302

Merged
merged 2 commits into from
May 14, 2020
Merged

Issue 2212 #2302

merged 2 commits into from
May 14, 2020

Conversation

xiphmont
Copy link
Contributor

Two patches implement the missing infrastructure needed to fix issue 2212 and allow proper Tile/LRU sizing in arbitrary 4:2:2 video.

@xiphmont xiphmont force-pushed the issue_2212 branch 2 times, most recently from 21e432f to 842933f Compare May 14, 2020 08:03
@coveralls
Copy link
Collaborator

coveralls commented May 14, 2020

Coverage Status

Coverage decreased (-0.3%) to 82.327% when pulling f322748 on xiphmont:issue_2212 into a4840d9 on xiph:master.

The versions of write_quiniform() used by the arithmetic packer and the uncompressed bitwriter vary considerably.  For some reason, the BitWriter uses a much 'narrower' implementation that overflows with inputs of more than a few bits.

This patch replaces the BitWriter's implementation with one like in the arithmetic packer.  This allows its use in coding non-uniform tile header fields.
Copy link
Collaborator

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with a few minor comments. Passes my reproduction: #2224 (comment)
If rebased against 03a11a2 on master, the reproduction also doesn't desync with CDEF and LRF enabled.

src/tiling/tiler.rs Outdated Show resolved Hide resolved
src/header.rs Outdated Show resolved Hide resolved
src/header.rs Outdated Show resolved Hide resolved
When doing loop filter RDO inline with the rest of the tile coding,
LRUs must align to tile boundaries.  An unexpected corner case means
that chroma LRUs must have an even superblock width in 4:2:2 video, as
LRUs must always be square.  As a result, that means tiles must also
have an even superblock width.

As tile width must be adjusted in this case, it also means we can't
use the spec's 'tile uniform spacing' mode, which would produce odd
superblock width tiles in, eg, 1080p 4:2:2 video. This patch also
implements explicit per-tile sizing the the frame OBU header.
@xiphmont xiphmont merged commit 51f0eed into xiph:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants