Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (js_api.yml): Fix wasm-pack build #2479

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

Urhengulas
Copy link
Contributor

@Urhengulas Urhengulas commented Aug 1, 2020

Add --dev to wasm-pack build. This is needed, because of rustwasm/wasm-pack#886.

This should be reverted as soon it is fixed in wasm-pack.

Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo in the commit.

It looks fine to me

Add `--dev` to `wasm-pack build`. This is needed, because of
rustwasm/wasm-pack#886.
@Urhengulas Urhengulas changed the title CI (js_api.yml): Fix wasm-back build CI (js_api.yml): Fix wasm-pack build Aug 1, 2020
@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2020

Coverage Status

Coverage decreased (-0.1%) to 82.274% when pulling 03d46ea on Urhengulas:fix-jsapi-ci into c200bc2 on xiph:master.

@Urhengulas Urhengulas requested a review from lu-zero August 3, 2020 10:32
@Urhengulas Urhengulas self-assigned this Aug 3, 2020
@Urhengulas Urhengulas added the CI CI Related issues label Aug 3, 2020
@lu-zero lu-zero merged commit d41b11a into xiph:master Aug 3, 2020
@Urhengulas Urhengulas deleted the fix-jsapi-ci branch August 3, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI Related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants