Add developer CLI flags for tuning encoder internals #3047
Conversation
shssoichiro
force-pushed
the
expose-options-2
branch
3 times, most recently
from
ed552c4
to
5fa188d
Compare
Codecov ReportBase: 86.41% // Head: 86.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3047 +/- ##
==========================================
- Coverage 86.41% 86.36% -0.05%
==========================================
Files 84 83 -1
Lines 33158 33085 -73
==========================================
- Hits 28652 28573 -79
- Misses 4506 4512 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Everything seems good on my end, as all flags seem to work(except --ip-qidx-ratio as I haven't tested it yet). |
|
What is wrong with ip-qidx-ratio? |
|
I should have been clearer: I haven't tested it yet :P |
|
Okay, well I will tell you from my testing in AWCY... It doesn't seem to work. :p at least it did not result in the output changing, which means it did not do what I wanted it to do. |
shssoichiro
force-pushed
the
expose-options-2
branch
2 times, most recently
from
f37702c
to
bbd0291
Compare
shssoichiro
force-pushed
the
expose-options-2
branch
from
bbd0291
to
a5222bd
Compare
Currently adds the following: - `--deblock-strength` - `--deblock-sharpness` - `--ip-ratio` - `--pb-ratio` - `--b-ratio` - `--temporal-rdo-strength` These flags will be available only if the `devel` feature flag is active, as they are intended to be used to ease development and not to be tweaked by end users. rav1e continues to subscribe to the philosophy that end users should not need to be cargo culting their command lines to get optimal results, and we would prefer to tune the encoder internals so that users do not have to.
shssoichiro
force-pushed
the
expose-options-2
branch
from
a5222bd
to
91ca870
Compare
Currently adds the following:
--deblock-strength--deblock-sharpness--ip-qidx-ratio--temporal-rdo-strengthThese flags will be available only if the
develfeature flag is active, as they are intended to be used to ease development and not to be tweaked by end users. rav1e continues to subscribe to the philosophy that end users should not need to be cargo culting their command lines to get optimal results, and we would prefer to tune the encoder internals so that users do not have to. This change helps us do that.