Move the benchmarks to Criterion #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me as a dev dependency, but that means there is no chance of removing external dependencies for benchmarking, so I would like to have @tdaede's opinion. Also, if you could produce a sample output that would be interesting to see. |
|
here the full output. |
|
That's actually really nice, ffmpeg and x264 internal benchmarks have similar functionality. I don't have any problem depending on criterion for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It produces more information including pretty graphs and immediate speedup/slowdown evaluation compared to previous runs.
Solves #398 by other means.