-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows and CMake support #88
base: master
Are you sure you want to change the base?
Conversation
Regarding eb45832: I would do something like mumble-voip/rnnoise@b30f2bb, instead. |
Very welcome change! Autotools, VLAs and overlap with Opus source code are really annoying. The code does high quality denoising, but once you start deploying it on different platforms you realize it needs a lot of TLC around compilation/build process |
Is there a reason why this was never merged? |
I'm not heavily involved in the development, but took the chance to merge the C++ header fix in #131, causing this change to no longer merge cleanly. Perhaps you can rebase it without the header change? |
@petterreinholdtsen I rebased and removed the header changes. |
@almogh52 maybe you also want to have a look at my changes based on your branch which can be found here: alfatraining@7d6f71f These changes are mostly carried over from community-contributed CMake code for libspeex. |
This pull request also remove two symbols from the list of exported symbols in the library. Anyway, I suspect the different parts of this pull request should be handled and evaluated separately. At least I believe the introduction of a parallel build system should be decided independently of moving several local variables to the heap. Perhaps better to make separate pull reqeusts for each set of changes? |
Once #164 is merged you can drop the VLA-related changes and just add to the CMake project the following: if(MSVC)
target_compile_definitions(rnnoise PRIVATE "USE_MALLOC")
endif() |
@almoghamdani LNK2019 unreferenced symbol _opus_fft_c, _forward_transform refered from testRNNoise xxxxxxxx\testRNNoise\rnnoise.lib(denoise.obj) |
This PR includes the following changes: