Fix not being able to encode byte slice #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbjarre
force-pushed
the
fix/byte-slice-repeated
branch
from
f7b84f6 to
29d352a
Compare
|
Sorry, managed to push all of the formatting changes but not the actual code change. Force pushed with the actual update. |
This patch introduces a check when marshalling a interface type based on the INT32 parquet type by defensively checking if it's a uint8, and therefore handling the byte case without panicing. Added a simple test case to cover the intended usecase.
lbjarre
force-pushed
the
fix/byte-slice-repeated
branch
from
29d352a to
ed94266
Compare
|
this change may not be a general way to support byte array. I'm considering to support it. |
|
I faced same issue recently #582. But this implementation is going to have each byte as int32 correct? Don't you think this is an in efficient way to store a single byte in 4 byte integer format? Please correct me if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a check when marshalling a interface type based
on the INT32 parquet type by defensively checking if it's a uint8, and
therefore handling the byte case without panicing.
Added a simple test case to cover the intended usecase.
Handles some of the issues raised in #321, though more convenient encoding of a byte slice as a
BYTE_ARRAYmight be better.