-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 设计模式进阶 #4982
iOS 设计模式进阶 #4982
Conversation
工作量可能较大 |
校对认领 |
@swants 好的呢 🍺 |
校对认领 |
@kirinzer 妥妥哒 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
翻译的不错, 但是不得不吐槽下,这篇教程真是老太太的裹脚布——又臭又长。
虽然特别长,但大部分都是代码及对代码的解释,没什么翻译难度。但还是要给译者加个鸡腿,工作量真是太大了。
@kirinzer 记得校对哈 |
@leviding 校对完成 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iWeslie 是指代码格式的问题,还是编译可能存在的问题? |
@iWeslie 我看完了,可以 merge 艾特我 |
@iWeslie SquareShapeView, GameViewController 缩进有点问题,代码 Xcode 跑过没有问题 |
具体在那边呢,我没有找到,不清楚你说的啥地方的缩进 @kirinzer |
@iWeslie 在 translated 38% 这次提交里可以看到,上面说的两个类,注释缩进没有和代码对齐。 |
shape2.sideLength = Utils.randomBetweenLower(0.3, andUpper: 0.8) | ||
override func viewDidLoad() { | ||
super.viewDidLoad() | ||
// 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释缩进问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirinzer 我怕是搞不懂 GitHub 的逻辑,里面那个我确实是用的一个 Tab 符号,但是显示效果好像有 8 个空格,其他正常显示的地方好像都是用的 4 个空格而不是一个 Tab,这个就不管它了吧
// 2 | ||
if showOutline { | ||
outlineColor.setStroke() | ||
// 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释缩进问题
@iWeslie 已经 merge 啦~ 快快麻溜发布到掘金然后给我发下链接,方便及时添加积分哟。 掘金翻译计划有自己的知乎专栏,你也可以投稿哈,推荐使用一个好用的插件。 |
译文翻译完成,resolve #4845