Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 设计模式进阶 #4982

Merged

Conversation

iWeslie
Copy link
Contributor

@iWeslie iWeslie commented Jan 13, 2019

译文翻译完成,resolve #4845

@iWeslie
Copy link
Contributor Author

iWeslie commented Jan 13, 2019

工作量可能较大
@leviding 请求三人及三人以上校对
有想校对的可以一起来,文章中不恰当指出,多人一起讨论。
@kirinzer @LoneyIsError @atuooo @swants @Chunk49 @phxnirvana

@leviding leviding added the iOS label Jan 14, 2019
@swants
Copy link

swants commented Jan 17, 2019

校对认领

@fanyijihua
Copy link
Collaborator

@swants 好的呢 🍺

@kirinzer
Copy link
Contributor

校对认领

@fanyijihua
Copy link
Collaborator

@kirinzer 妥妥哒 🍻

Copy link

@swants swants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译的不错, 但是不得不吐槽下,这篇教程真是老太太的裹脚布——又臭又长。
虽然特别长,但大部分都是代码及对代码的解释,没什么翻译难度。但还是要给译者加个鸡腿,工作量真是太大了。

@leviding
Copy link
Member

@kirinzer 记得校对哈

@kirinzer
Copy link
Contributor

@leviding 校对完成

@leviding leviding added the enhancement 等待译者修改 label Jan 24, 2019
Copy link
Contributor Author

@iWeslie iWeslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有人再检查一遍代码了吗 @swants @kirinzer

@leviding leviding added 标注 待管理员 Review and removed enhancement 等待译者修改 labels Jan 27, 2019
@kirinzer
Copy link
Contributor

@iWeslie 是指代码格式的问题,还是编译可能存在的问题?

leviding
leviding previously approved these changes Jan 28, 2019
@leviding
Copy link
Member

@iWeslie 我看完了,可以 merge 艾特我

@leviding leviding added Tag 一次校对修改完成 and removed 标注 待管理员 Review labels Jan 28, 2019
@iWeslie
Copy link
Contributor Author

iWeslie commented Jan 28, 2019

@leviding 可以直接merge啦,pr先别关。
@kirinzer 都可以看一下,我怕有小错误,虽然已经总体看过了

@kirinzer
Copy link
Contributor

@iWeslie SquareShapeView, GameViewController 缩进有点问题,代码 Xcode 跑过没有问题

@iWeslie
Copy link
Contributor Author

iWeslie commented Jan 29, 2019

具体在那边呢,我没有找到,不清楚你说的啥地方的缩进 @kirinzer

@kirinzer
Copy link
Contributor

@iWeslie 在 translated 38% 这次提交里可以看到,上面说的两个类,注释缩进没有和代码对齐。
还有 tappedView in 这个在 block 里有两处换行了,应该跟在 { 后面

shape2.sideLength = Utils.randomBetweenLower(0.3, andUpper: 0.8)
override func viewDidLoad() {
super.viewDidLoad()
// 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释缩进问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirinzer 我怕是搞不懂 GitHub 的逻辑,里面那个我确实是用的一个 Tab 符号,但是显示效果好像有 8 个空格,其他正常显示的地方好像都是用的 4 个空格而不是一个 Tab,这个就不管它了吧

// 2
if showOutline {
outlineColor.setStroke()
// 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释缩进问题

@leviding leviding merged commit 5e00237 into xitu:master Jan 30, 2019
@leviding
Copy link
Member

@iWeslie 已经 merge 啦~ 快快麻溜发布到掘金然后给我发下链接,方便及时添加积分哟。

掘金翻译计划有自己的知乎专栏,你也可以投稿哈,推荐使用一个好用的插件
专栏地址:https://zhuanlan.zhihu.com/juejinfanyi

@leviding leviding added 翻译完成 and removed Tag 一次校对修改完成 正在校对 labels Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 设计模式进阶
5 participants