Add a Gitter chat badge to README.md #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miha-plesko
pushed a commit
that referenced
this pull request
Sep 2, 2019
Only accept `Hash` results when parsing JSON. Other related models
expect an array of hashes when working with `#parsed_stdout`, so if the
digested stdout output includes lines that like the following:
- "some output"
- 12345
They will still be parsed properly by `JSON.parse`, but methods
expecting a `["stdout"]` key from each of the results in the array will
result in an error.
The downside of this approach is that this ends up leading to output
missing from the digested result, so for example:
# Sample artifacts/result/stdout
{"uuid": "9dc88a31-...", "counter": 1, "stdout": ""}
{"uuid": "9dc88a31-...", "counter": 2, "stdout": "\r\nPLAY [List Variables] **********..."}
32m "aw",[0m
[0;32m "geeze",[0m
[0;32m "some",[0m
[0;32m "playbook",[0m
[0;32m "output",[0m
[0;32m "leaked..."[0m
[0;32m ],[0m
[0;32m [[0m
[0;32m 12345,[0m
[0;32m 23456[0m
[0;32m ],[0m{"uuid": "9dc88a31-...", "counter": 3, "stdout": ""[0;32m{[0m [0;32m [[0m [0;32m \"aw\",[0m [0;32m \"geeze\",[0m...""}
{"uuid": "9dc88a31-...", "counter": 4, "stdout": "\r\nPLAY RECAP **********..."}
Where the second to last line is partial content from the "leaked"
stdout and the next line of json that contained the next section of
content. This will be addressed more in follow up commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xlab-si/manageiq now has a Chat Room on Gitter
@cankarm has just created a chat room. You can visit it here: https://gitter.im/xlab-si/manageiq.
This pull-request adds this badge to your README.md:
If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.