Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pdf support #105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

freetown113
Copy link

add minimal necessary logic to support handling of the files in pdf format

add minimal necessary logic to support handling of the files in pdf format
@Timothyxxx
Copy link
Member

Nice work, we will go through it very soon!

@BlankCheng
Copy link
Contributor

Hi, thanks for your great contribution. The code has some circular import issues. I think it is because DocumentSummaryExecutor is imported in document.py but it also imports DocumentDataModel from document.py.
Would you mind trying to fix that and testing it on the local host? Thanks.

remove unnecessary parts
@freetown113
Copy link
Author

Yes, I shouldn't leave this part of the code in the PR. It was a kind of a draft for the next possible enhancement. I removed it. Please check it now.

Copy link

github-actions bot commented Dec 8, 2023

This PR is stale because it has been open 3 days with no activity.

@github-actions github-actions bot added the Stale label Dec 8, 2023
@BlankCheng
Copy link
Contributor

Hi, I've fixed extra imports to avoid circular imports and added .pdf extension support to let it successfully be run locally. I think it looks good to me overall.
However, due to some openai key issue, I cannot test the full functionality as proposed. Would you or other participants be able to local host it and test the pdf functionalities?

@github-actions github-actions bot removed the Stale label Dec 19, 2023
@Timothyxxx
Copy link
Member

@freetown113

Copy link

This PR is stale because it has been open 3 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants