-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pdf support #105
base: main
Are you sure you want to change the base?
add pdf support #105
Conversation
add minimal necessary logic to support handling of the files in pdf format
Nice work, we will go through it very soon! |
Hi, thanks for your great contribution. The code has some circular import issues. I think it is because |
remove unnecessary parts
Yes, I shouldn't leave this part of the code in the PR. It was a kind of a draft for the next possible enhancement. I removed it. Please check it now. |
This PR is stale because it has been open 3 days with no activity. |
Hi, I've fixed extra imports to avoid circular imports and added .pdf extension support to let it successfully be run locally. I think it looks good to me overall. |
This PR is stale because it has been open 3 days with no activity. |
add minimal necessary logic to support handling of the files in pdf format