Script to generate data4mask.py and data4info.py #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On follow-up of issue #84
This was meant to be a question about whether this feature would be useful, but I wanted to check that it was possible to generate the existing data from the isbn-international.org range file XML first. In the process of checking, I'd basically finished writing the script, so here it is as a draft proposal.
If anything needs renaming, or moving, let me know.
I have never seen the closed-source isbntools-dev, and do not know how the current isbnlib dev pipeline works, so I'm not sure how well this will integrate in to your current process. I thought it'd be nice to have a open source mask refresh code which can be generated on demand from the official isbn-international source.
I expect this may need some work to be properly integrated, and I admit I'm not sure who will run this script and when, or even if this belongs in a separate public repo since there are no other stand-alone scripts in this repo.
Changes proposed in this pull request:
Open source script to create data4mask.py and data4info.py from a request to isbn-international.org ISBN range file XML
Minor content changes to data4mask.py and data4info.py , but the functionality should be identical.
RDDATE is taken from
MessageDate
in the source export_rangemessage.xml (I don't know if it was before)isbnlib
is a very useful tool, thank you for creating it! I hope this is helpful. Happy to discuss.@xlcnd