Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to generate data4mask.py and data4info.py #120

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

hornc
Copy link

@hornc hornc commented Jan 29, 2023

On follow-up of issue #84

This was meant to be a question about whether this feature would be useful, but I wanted to check that it was possible to generate the existing data from the isbn-international.org range file XML first. In the process of checking, I'd basically finished writing the script, so here it is as a draft proposal.

If anything needs renaming, or moving, let me know.

I have never seen the closed-source isbntools-dev, and do not know how the current isbnlib dev pipeline works, so I'm not sure how well this will integrate in to your current process. I thought it'd be nice to have a open source mask refresh code which can be generated on demand from the official isbn-international source.

I expect this may need some work to be properly integrated, and I admit I'm not sure who will run this script and when, or even if this belongs in a separate public repo since there are no other stand-alone scripts in this repo.

Changes proposed in this pull request:

  • Open source script to create data4mask.py and data4info.py from a request to isbn-international.org ISBN range file XML

  • Minor content changes to data4mask.py and data4info.py , but the functionality should be identical.

  • RDDATE is taken from MessageDate in the source export_rangemessage.xml (I don't know if it was before)

isbnlib is a very useful tool, thank you for creating it! I hope this is helpful. Happy to discuss.

@xlcnd

@xlcnd
Copy link
Owner

xlcnd commented Jan 30, 2023

HI. Thanks for your script.

This is a simpler version of isbntools-dev, some tests and hedge cases are missing but most of the times it should work. However, after many pros and cons I decided (long ago) to not integrate the tool in isbnlib.

Anyway, I suggest that you publish it as a script addon that could be useful for some power users! The present plugin framework used by isbnlib doesn't allow this kind of integration.

@xlcnd xlcnd added the info label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants