Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split config to multiple modules #1025

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

JianMinTang
Copy link
Contributor

@JianMinTang JianMinTang commented Nov 18, 2024

fixed #604

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

the configurations are only in single module that doesn't handy to manage.

  • what changes does this pull request make?

i organized these configurations into multiple modules.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

WIP: use builder pattern to create!

Signed-off-by: JianMinTang <jmtangcs@gmail.com>
@mergify mergify bot requested a review from a team November 18, 2024 09:06
Copy link

mergify bot commented Nov 18, 2024

@JianMinTang Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft November 18, 2024 09:29
@mergify mergify bot added the CI:fail CI has failed label Nov 18, 2024
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Signed-off-by: JianMinTang <jmtangcs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:fail CI has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: config
1 participant