Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation #157

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Validation #157

merged 1 commit into from
Feb 1, 2023

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Execute etcd validation test automatically
  • what changes does this pull request make?
    Add a script to validate, and run this script in
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No

based on #153

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #157 (356e307) into master (2f4de6c) will decrease coverage by 0.30%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   70.59%   70.30%   -0.30%     
==========================================
  Files          61       62       +1     
  Lines       10638    10684      +46     
==========================================
+ Hits         7510     7511       +1     
- Misses       3128     3173      +45     
Impacted Files Coverage Δ
xline/src/bin/lock_client.rs 67.39% <67.39%> (ø)
curp/src/shutdown.rs 34.28% <0.00%> (-5.72%) ⬇️
curp/src/server/bg_tasks.rs 92.21% <0.00%> (-1.92%) ⬇️
xline/src/server/xline_server.rs 86.16% <0.00%> (-1.89%) ⬇️
curp/src/server/mod.rs 83.36% <0.00%> (-1.71%) ⬇️
curp/src/client.rs 63.46% <0.00%> (-0.91%) ⬇️
curp/src/server/cmd_worker.rs 88.67% <0.00%> (-0.63%) ⬇️
xline/src/storage/lease_store/mod.rs 85.95% <0.00%> (-0.58%) ⬇️
xline/src/storage/kv_store.rs 87.40% <0.00%> (-0.16%) ⬇️
curp/src/error.rs 20.42% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@themanforfree themanforfree force-pushed the validation branch 3 times, most recently from fa733c9 to 7c6fc94 Compare January 19, 2023 07:55
@themanforfree themanforfree marked this pull request as ready for review January 31, 2023 12:08
@Phoenix500526 Phoenix500526 merged commit 44e92b0 into xline-kv:master Feb 1, 2023
@themanforfree themanforfree deleted the validation branch February 3, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants