-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Xline client kv #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 54.42% 52.81% -1.62%
==========================================
Files 89 89
Lines 12822 13207 +385
Branches 12822 13207 +385
==========================================
- Hits 6979 6975 -4
- Misses 5392 5781 +389
Partials 451 451
|
bsbds
force-pushed
the
client-kv
branch
4 times, most recently
from
June 16, 2023 11:58
0b533be
to
c3db5e9
Compare
iGxnon
reviewed
Jun 19, 2023
rogercloud
reviewed
Jun 19, 2023
bsbds
force-pushed
the
client-kv
branch
3 times, most recently
from
June 21, 2023 11:52
3d4ad3d
to
af3a578
Compare
themanforfree
approved these changes
Jun 25, 2023
Phoenix500526
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement kv client in
xline-client
based on #317
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)