Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Xline client kv #318

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Feature/Xline client kv #318

merged 2 commits into from
Jun 27, 2023

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Jun 9, 2023

Implement kv client in xline-client

based on #317

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds mentioned this pull request Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #318 (e17bd83) into master (c60a67d) will decrease coverage by 1.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   54.42%   52.81%   -1.62%     
==========================================
  Files          89       89              
  Lines       12822    13207     +385     
  Branches    12822    13207     +385     
==========================================
- Hits         6979     6975       -4     
- Misses       5392     5781     +389     
  Partials      451      451              
Impacted Files Coverage Δ
xline-client/src/clients/kv.rs 0.00% <0.00%> (ø)
xline/src/server/auth_server.rs 0.00% <0.00%> (ø)
xline/src/server/kv_server.rs 39.26% <0.00%> (+0.10%) ⬆️
xline/src/server/lease_server.rs 0.00% <0.00%> (ø)
xline/src/server/lock_server.rs 0.00% <0.00%> (ø)
xlineapi/src/lib.rs 55.94% <0.00%> (+0.81%) ⬆️

... and 5 files with indirect coverage changes

@bsbds bsbds marked this pull request as ready for review June 14, 2023 13:49
@bsbds bsbds force-pushed the client-kv branch 4 times, most recently from 0b533be to c3db5e9 Compare June 16, 2023 11:58
xline-client/src/clients/kv.rs Show resolved Hide resolved
xline-client/src/clients/kv.rs Show resolved Hide resolved
xline-client/src/clients/kv.rs Show resolved Hide resolved
xline-client/tests/kv.rs Show resolved Hide resolved
xline-client/tests/kv.rs Outdated Show resolved Hide resolved
xlineapi/src/lib.rs Outdated Show resolved Hide resolved
xline-client/src/clients/kv.rs Outdated Show resolved Hide resolved
xline-client/tests/kv.rs Outdated Show resolved Hide resolved
@bsbds bsbds force-pushed the client-kv branch 3 times, most recently from 3d4ad3d to af3a578 Compare June 21, 2023 11:52
xline/src/server/auth_server.rs Outdated Show resolved Hide resolved
xline/src/server/kv_server.rs Outdated Show resolved Hide resolved
xline/src/server/kv_server.rs Outdated Show resolved Hide resolved
xline/src/server/lease_server.rs Outdated Show resolved Hide resolved
xline/src/server/lock_server.rs Outdated Show resolved Hide resolved
@Phoenix500526 Phoenix500526 merged commit eea86a0 into xline-kv:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants