Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Xline client auth #320

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Feature/Xline client auth #320

merged 2 commits into from
Jul 11, 2023

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Jun 9, 2023

Implement auth client in xline-client

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds mentioned this pull request Jun 9, 2023
@bsbds bsbds force-pushed the client-auth branch 2 times, most recently from 0dde5ac to 90a030c Compare June 27, 2023 08:40
@bsbds bsbds marked this pull request as ready for review June 27, 2023 08:41
xline-client/src/clients/auth.rs Outdated Show resolved Hide resolved
xline-client/src/clients/auth.rs Outdated Show resolved Hide resolved
xline-client/tests/auth.rs Outdated Show resolved Hide resolved
xline-client/tests/auth.rs Outdated Show resolved Hide resolved
xline-client/src/lib.rs Outdated Show resolved Hide resolved
themanforfree
themanforfree previously approved these changes Jul 7, 2023
iGxnon
iGxnon previously approved these changes Jul 7, 2023
bsbds added 2 commits July 7, 2023 13:51
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds dismissed stale reviews from iGxnon and themanforfree via fc273c5 July 7, 2023 05:53
@bsbds bsbds requested review from themanforfree and iGxnon July 7, 2023 07:16
@xline-kv xline-kv deleted a comment from codecov bot Jul 10, 2023
@Phoenix500526 Phoenix500526 merged commit 5068a2b into xline-kv:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants