Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/member add single #382

Merged

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:
First PR of #306

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    make curp manage content other than Command.
  • what changes does this pull request make?
    use Arc to share LogEntry, let conflict checked mpmc channel process LogEntry instead of Command
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 78.65% and project coverage change: -0.02% ⚠️

Comparison is base (9b747ec) 53.60% compared to head (405a02d) 53.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   53.60%   53.58%   -0.02%     
==========================================
  Files         102      102              
  Lines       15944    15976      +32     
  Branches    15944    15976      +32     
==========================================
+ Hits         8546     8561      +15     
- Misses       6878     6893      +15     
- Partials      520      522       +2     
Files Changed Coverage Δ
curp/src/server/curp_node.rs 24.46% <0.00%> (ø)
curp/src/server/storage/mod.rs 0.00% <ø> (ø)
curp/src/server/storage/db.rs 67.64% <50.00%> (ø)
curp/src/log_entry.rs 52.38% <52.63%> (-22.62%) ⬇️
curp/src/server/raw_curp/mod.rs 66.14% <55.00%> (-0.58%) ⬇️
...urp/src/server/cmd_worker/conflict_checked_mpmc.rs 84.43% <87.17%> (-0.65%) ⬇️
curp/src/server/cmd_worker/mod.rs 70.81% <88.23%> (-1.53%) ⬇️
curp/src/server/raw_curp/log.rs 91.16% <96.96%> (+0.11%) ⬆️
curp/src/rpc/mod.rs 26.94% <100.00%> (ø)
curp/src/server/raw_curp/tests.rs 69.01% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: themanforfree <themanforfree@gmail.com>
…chine

Signed-off-by: themanforfree <themanforfree@gmail.com>
…ands

Signed-off-by: themanforfree <themanforfree@gmail.com>
@themanforfree themanforfree force-pushed the feature/member-add-single branch from 6921091 to 405a02d Compare August 7, 2023 01:30
@iGxnon iGxnon self-requested a review August 9, 2023 11:15
@themanforfree themanforfree mentioned this pull request Aug 10, 2023
4 tasks
@Phoenix500526 Phoenix500526 merged commit 22f34e8 into xline-kv:master Aug 10, 2023
@themanforfree themanforfree deleted the feature/member-add-single branch August 10, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants