Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto compactor #401

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

Phoenix500526
Copy link
Collaborator

@Phoenix500526 Phoenix500526 commented Jul 27, 2023

Please briefly answer these questions:
based on pr #399 and #394

  1. implement auto-compaction logic, read [Proposal] Compaction Feature Designed Doc #188 for more details
  2. break down the dependencies between CurpServer and CurpClient.
  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 61.05% and project coverage change: +0.12% 🎉

Comparison is base (b4ef3c8) 53.48% compared to head (39478eb) 53.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   53.48%   53.61%   +0.12%     
==========================================
  Files         100      102       +2     
  Lines       15531    15944     +413     
  Branches    15531    15944     +413     
==========================================
+ Hits         8307     8548     +241     
- Misses       6725     6877     +152     
- Partials      499      519      +20     
Files Changed Coverage Δ
curp/src/log_entry.rs 75.00% <ø> (ø)
curp/src/rpc/mod.rs 26.94% <ø> (ø)
curp/src/server/cmd_worker/mod.rs 72.34% <ø> (ø)
curp/src/server/curp_node.rs 24.46% <ø> (+0.15%) ⬆️
curp/src/server/gc.rs 86.84% <ø> (ø)
curp/src/server/mod.rs 0.00% <ø> (ø)
curp/src/server/raw_curp/log.rs 91.04% <ø> (ø)
curp/src/server/raw_curp/mod.rs 66.57% <ø> (+0.61%) ⬆️
curp/src/server/raw_curp/tests.rs 69.01% <ø> (ø)
curp/src/snapshot.rs 87.50% <ø> (ø)
... and 16 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Phoenix500526 Phoenix500526 marked this pull request as ready for review July 27, 2023 23:37
@Phoenix500526 Phoenix500526 marked this pull request as draft July 29, 2023 04:45
@Phoenix500526 Phoenix500526 marked this pull request as ready for review July 30, 2023 01:25
@Phoenix500526 Phoenix500526 force-pushed the feature/auto-compactor branch from 0014215 to ca23a44 Compare August 1, 2023 01:22
@Phoenix500526 Phoenix500526 requested a review from bsbds August 1, 2023 06:18
@Phoenix500526 Phoenix500526 force-pushed the feature/auto-compactor branch 4 times, most recently from 7f1f239 to 356fb9d Compare August 4, 2023 08:26
iGxnon
iGxnon previously approved these changes Aug 4, 2023
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
Refs: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
* using static generic instead of dynamic trait object
* improve revision window's implementation

Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@Phoenix500526 Phoenix500526 force-pushed the feature/auto-compactor branch 2 times, most recently from ecbf871 to 6c96640 Compare August 4, 2023 11:37
@Phoenix500526 Phoenix500526 added this to the v0.5.0 milestone Aug 4, 2023
@Phoenix500526 Phoenix500526 linked an issue Aug 4, 2023 that may be closed by this pull request
Closes: 188
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@Phoenix500526 Phoenix500526 force-pushed the feature/auto-compactor branch from 6c96640 to 39478eb Compare August 4, 2023 12:23
@Phoenix500526 Phoenix500526 requested a review from iGxnon August 4, 2023 12:47
@mergify mergify bot merged commit c73ec49 into xline-kv:master Aug 4, 2023
@Phoenix500526 Phoenix500526 deleted the feature/auto-compactor branch September 23, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Compaction Feature Designed Doc
4 participants