-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: build client without ServerId
#412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themanforfree
force-pushed
the
refactor/client
branch
from
August 7, 2023 04:20
0cbd181
to
5099e45
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 53.69% 53.73% +0.04%
==========================================
Files 101 101
Lines 15913 16074 +161
Branches 15913 16074 +161
==========================================
+ Hits 8545 8638 +93
- Misses 6847 6912 +65
- Partials 521 524 +3
☔ View full report in Codecov by Sentry. |
bsbds
reviewed
Aug 7, 2023
themanforfree
force-pushed
the
refactor/client
branch
2 times, most recently
from
August 8, 2023 01:24
4138d38
to
2915748
Compare
add client builder add `fetch_cluster` rpc allows the client to build without `ServerId`, which automatically fetch the cluster information from the server Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
themanforfree
force-pushed
the
refactor/client
branch
from
August 8, 2023 05:17
96cd60c
to
ec6245c
Compare
This was referenced Aug 8, 2023
bsbds
reviewed
Aug 10, 2023
themanforfree
force-pushed
the
refactor/client
branch
from
August 10, 2023 09:53
ee14f03
to
d6f3466
Compare
Signed-off-by: themanforfree <themanforfree@gmail.com>
themanforfree
force-pushed
the
refactor/client
branch
from
August 10, 2023 10:20
d6f3466
to
bad4986
Compare
Phoenix500526
approved these changes
Aug 11, 2023
bsbds
approved these changes
Aug 11, 2023
Phoenix500526
added
the
Improvement
Refactor or optimization, including process, performance or something like that
label
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
#306
build client without
ServerId
add client builder
add
fetch_cluster
rpcallows the client to build without
ServerId
, which automatically fetch the cluster information from the serveryes,
Client::new
is removed, use client builder instead