-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: command after sync serialization #422
refactor: command after sync serialization #422
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 54.02% 54.14% +0.11%
==========================================
Files 101 101
Lines 16630 16739 +109
Branches 16630 16739 +109
==========================================
+ Hits 8985 9063 +78
- Misses 7101 7124 +23
- Partials 544 552 +8
☔ View full report in Codecov by Sentry. |
9039419
to
f7d812f
Compare
The files generated from .proto files for Rust are organized into workspaces, but if my generated files are all in one project. The command.proto and error.proto files have the same name, and the Empty struct is duplicated. At runtime, the project will error due to the duplication between the two files. proto: file "error.proto" is already registered
proto: file "error.proto" has a name conflict over errorpb.Empty
proto: message errorpb.Empty is already registered
proto: file "command.proto" is already registered But, this issue can be ignored by setting an environment variable. GOLANG_PROTOBUF_REGISTRATION_CONFLICT="ignore" |
I replaced the two |
6443686
to
7345366
Compare
227f4e5
to
1a8fc2e
Compare
6092e82
to
7e2053b
Compare
Please squash commits in this PR, some of them are too granular. |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> chore: rename `PbSerialize` to `PbCodec` Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
7e2053b
to
b30fa33
Compare
Described in: #420
Based on: #421
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)