Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement xlinectl snapshot and auth commands #425

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Aug 23, 2023

Based on: #424

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.21% 🎉

Comparison is base (ac697cb) 54.09% compared to head (8a3c874) 54.30%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   54.09%   54.30%   +0.21%     
==========================================
  Files         102      102              
  Lines       17150    17355     +205     
  Branches    17150    17355     +205     
==========================================
+ Hits         9277     9425     +148     
- Misses       7306     7359      +53     
- Partials      567      571       +4     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds force-pushed the xlinectl-snapshot-auth branch from 326f62e to c9e6ddf Compare September 20, 2023 01:08
@bsbds bsbds marked this pull request as ready for review September 20, 2023 01:14
themanforfree
themanforfree previously approved these changes Sep 21, 2023
Copy link
Collaborator

@themanforfree themanforfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6dbffa9 into xline-kv:master Sep 22, 2023
17 checks passed
@Phoenix500526 Phoenix500526 added the enhancement New feature or request label Nov 18, 2023
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants