feature: add apply_conf_change method for RawCurp
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themanforfree
force-pushed
the
apply_conf_change
branch
from
af048e0 to
b72ffd3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 54.02% 54.29% +0.27%
==========================================
Files 102 102
Lines 17199 17378 +179
Branches 17199 17378 +179
==========================================
+ Hits 9291 9436 +145
- Misses 7341 7369 +28
- Partials 567 573 +6
☔ View full report in Codecov by Sentry. |
4 tasks
themanforfree
force-pushed
the
apply_conf_change
branch
from
b72ffd3 to
b5087f5
Compare
Merged
themanforfree
force-pushed
the
apply_conf_change
branch
from
b5087f5 to
da247f8
Compare
bsbds
reviewed
Sep 7, 2023
themanforfree
force-pushed
the
apply_conf_change
branch
3 times, most recently
from
e3ab157 to
d28e825
Compare
iGxnon
reviewed
Sep 11, 2023
|
BTW, can we directly use the etcd's protobuf definition of ConfChange? This way, we won't need to add an extra layer of translation in xline to the current definition of ConfChange. |
rogercloud
reviewed
Sep 12, 2023
rogercloud
reviewed
Sep 12, 2023
themanforfree
force-pushed
the
apply_conf_change
branch
from
00d5395 to
2780347
Compare
themanforfree
requested review from
rogercloud,
iGxnon,
Phoenix500526 and
bsbds
refactor data structures that need to be mutable Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
themanforfree
force-pushed
the
apply_conf_change
branch
from
2780347 to
4437b4b
Compare
There was a problem hiding this comment.
This PR should be based on PR #451 and PR xline-kv/curp-proto#2
iGxnon
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
#306
apply config change to curp
refactor data structures via
DashMap, and modify them when apply_conf_changeno