-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check the password on leader #435
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 54.09% 54.27% +0.17%
==========================================
Files 102 102
Lines 17150 17355 +205
Branches 17150 17355 +205
==========================================
+ Hits 9277 9419 +142
- Misses 7306 7363 +57
- Partials 567 573 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
54a9b4f
Signed-off-by: iGxnon <igxnon@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
AuthServer::authenticate
should not check password locally.what changes does this pull request make?
Move the
check_password
to the leader.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No