Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the password on leader #435

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: check the password on leader #435

merged 1 commit into from
Sep 21, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Aug 29, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    AuthServer::authenticate should not check password locally.

  • what changes does this pull request make?

    Move the check_password to the leader.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    No

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 71.14% and project coverage change: +0.17% 🎉

Comparison is base (ac697cb) 54.09% compared to head (a3779c2) 54.27%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   54.09%   54.27%   +0.17%     
==========================================
  Files         102      102              
  Lines       17150    17355     +205     
  Branches    17150    17355     +205     
==========================================
+ Hits         9277     9419     +142     
- Misses       7306     7363      +57     
- Partials      567      573       +6     
Files Changed Coverage Δ
curp/src/error.rs 54.19% <0.00%> (-0.42%) ⬇️
curp/src/server/curp_node.rs 22.38% <0.00%> (-0.21%) ⬇️
curp/src/server/mod.rs 0.00% <0.00%> (ø)
xline/src/server/auth_server.rs 0.00% <0.00%> (ø)
xline/src/server/lease_server.rs 0.00% <0.00%> (ø)
xline/src/server/xline_server.rs 0.00% <0.00%> (ø)
xline/src/storage/auth_store/store.rs 56.70% <0.00%> (-0.06%) ⬇️
curp/src/server/raw_curp/mod.rs 69.21% <74.71%> (+0.67%) ⬆️
curp/src/server/raw_curp/tests.rs 69.72% <75.00%> (+0.93%) ⬆️
curp/src/members.rs 88.12% <82.35%> (+4.03%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Phoenix500526
Phoenix500526 previously approved these changes Sep 4, 2023
Phoenix500526
Phoenix500526 previously approved these changes Sep 15, 2023
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themanforfree
themanforfree previously approved these changes Sep 20, 2023
Copy link
Collaborator

@themanforfree themanforfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon iGxnon dismissed stale reviews from themanforfree and Phoenix500526 via 54a9b4f September 21, 2023 02:05
Signed-off-by: iGxnon <igxnon@gmail.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0f30a29 into xline-kv:master Sep 21, 2023
17 checks passed
@iGxnon iGxnon deleted the fix/auth branch November 11, 2023 14:45
@Phoenix500526 Phoenix500526 added the bug Something isn't working label Nov 18, 2023
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants