Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learner #449

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Add learner #449

merged 5 commits into from
Oct 13, 2023

Conversation

themanforfree
Copy link
Collaborator

@themanforfree themanforfree commented Sep 14, 2023

Please briefly answer these questions:
#306

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@themanforfree themanforfree force-pushed the mc/add-learner branch 2 times, most recently from 083e4e9 to f450417 Compare September 19, 2023 14:37
@themanforfree themanforfree self-assigned this Sep 21, 2023
@themanforfree themanforfree added this to the v0.6.0 milestone Oct 7, 2023
@themanforfree themanforfree force-pushed the mc/add-learner branch 3 times, most recently from 50895a6 to e38c2e4 Compare October 12, 2023 04:55
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (601c710) 52.77% compared to head (4e2677e) 52.87%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   52.77%   52.87%   +0.10%     
==========================================
  Files         104      104              
  Lines       18156    18275     +119     
  Branches    18156    18275     +119     
==========================================
+ Hits         9581     9663      +82     
- Misses       8007     8035      +28     
- Partials      568      577       +9     
Files Coverage Δ
curp-test-utils/src/test_cmd.rs 77.81% <ø> (ø)
curp/src/server/raw_curp/tests.rs 73.93% <97.14%> (+1.70%) ⬆️
curp/src/rpc/mod.rs 25.16% <63.63%> (+3.95%) ⬆️
curp/src/members.rs 81.67% <42.85%> (-1.94%) ⬇️
curp/src/server/raw_curp/state.rs 91.08% <83.33%> (-2.78%) ⬇️
curp/src/server/curp_node.rs 15.35% <8.33%> (-0.09%) ⬇️
curp/src/server/raw_curp/mod.rs 68.07% <71.42%> (-0.87%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themanforfree themanforfree marked this pull request as ready for review October 12, 2023 05:03
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
curp/src/server/raw_curp/mod.rs Outdated Show resolved Hide resolved
curp/src/server/raw_curp/state.rs Outdated Show resolved Hide resolved
curp/src/server/curp_node.rs Outdated Show resolved Hide resolved
curp/src/members.rs Outdated Show resolved Hide resolved
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6102c7b into xline-kv:master Oct 13, 2023
18 checks passed
@themanforfree themanforfree deleted the mc/add-learner branch October 13, 2023 15:23
@Phoenix500526 Phoenix500526 added the enhancement New feature or request label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants