-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add learner #449
Merged
Merged
Add learner #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themanforfree
force-pushed
the
mc/add-learner
branch
2 times, most recently
from
September 19, 2023 14:37
083e4e9
to
f450417
Compare
themanforfree
force-pushed
the
mc/add-learner
branch
from
September 24, 2023 07:29
f450417
to
874a845
Compare
Merged
themanforfree
force-pushed
the
mc/add-learner
branch
3 times, most recently
from
October 12, 2023 04:55
50895a6
to
e38c2e4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 52.77% 52.87% +0.10%
==========================================
Files 104 104
Lines 18156 18275 +119
Branches 18156 18275 +119
==========================================
+ Hits 9581 9663 +82
- Misses 8007 8035 +28
- Partials 568 577 +9
☔ View full report in Codecov by Sentry. |
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
themanforfree
force-pushed
the
mc/add-learner
branch
from
October 12, 2023 07:15
e38c2e4
to
7c95b45
Compare
bsbds
reviewed
Oct 13, 2023
iGxnon
reviewed
Oct 13, 2023
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Signed-off-by: themanforfree <themanforfree@gmail.com>
Phoenix500526
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bsbds
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
#306
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)