Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execute out of order #454

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Sep 22, 2023

Closes: #438

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 73.60% and project coverage change: +0.23% 🎉

Comparison is base (ac697cb) 54.09% compared to head (8d94c55) 54.32%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   54.09%   54.32%   +0.23%     
==========================================
  Files         102      102              
  Lines       17150    17379     +229     
  Branches    17150    17379     +229     
==========================================
+ Hits         9277     9441     +164     
- Misses       7306     7364      +58     
- Partials      567      574       +7     
Files Changed Coverage Δ
curp/src/error.rs 54.19% <0.00%> (-0.42%) ⬇️
curp/src/server/curp_node.rs 22.38% <0.00%> (-0.21%) ⬇️
curp/src/server/mod.rs 0.00% <0.00%> (ø)
xline/src/server/lease_server.rs 0.00% <0.00%> (ø)
xline/src/server/xline_server.rs 0.00% <0.00%> (ø)
curp/src/server/raw_curp/mod.rs 69.05% <73.73%> (+0.51%) ⬆️
curp/src/server/raw_curp/tests.rs 70.55% <77.50%> (+1.76%) ⬆️
curp/src/members.rs 88.12% <82.35%> (+4.03%) ⬆️
curp/src/rpc/mod.rs 27.86% <84.00%> (+5.64%) ⬆️
curp/src/server/raw_curp/state.rs 94.08% <93.93%> (+0.88%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Closes: xline-kv#438

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds force-pushed the fix-execute-out-of-order branch from e252dd2 to 8d94c55 Compare September 22, 2023 05:36
@bsbds bsbds marked this pull request as ready for review September 22, 2023 06:55
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 60856f1 into xline-kv:master Sep 22, 2023
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
@Phoenix500526 Phoenix500526 added the bug Something isn't working label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: command may execute out of order after re-elect
3 participants