Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: benchmark client cannot connect to server #462

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Phoenix500526
Copy link
Collaborator

closes: 461

Please briefly answer these questions:
FYI: issue #461

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

closes: 461
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (0aca7ab) 54.31% compared to head (578f570) 54.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   54.31%   54.27%   -0.04%     
==========================================
  Files         102      102              
  Lines       17481    17491      +10     
  Branches    17481    17491      +10     
==========================================
  Hits         9494     9494              
- Misses       7413     7423      +10     
  Partials      574      574              
Files Changed Coverage Δ
benchmark/src/runner.rs 8.18% <0.00%> (-0.39%) ⬇️
xline/src/server/auth_server.rs 0.00% <ø> (ø)
xline/src/storage/compact/mod.rs 30.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon self-requested a review September 25, 2023 07:50
@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Sep 25, 2023

closes: 461

I think it won't close the issue,

@Phoenix500526 Phoenix500526 linked an issue Sep 25, 2023 that may be closed by this pull request
1 task
@Phoenix500526 Phoenix500526 merged commit 18ca614 into xline-kv:master Sep 25, 2023
@Phoenix500526 Phoenix500526 deleted the fix/benchmark branch September 25, 2023 08:59
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
@Phoenix500526 Phoenix500526 added the bug Something isn't working label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Benchmark CI failed since the client cannot connect to xline server
4 participants