Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cluster client #465

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Feat/cluster client #465

merged 3 commits into from
Oct 11, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Sep 27, 2023

Base on #464

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (e726fa8) 53.46% compared to head (87f35d8) 53.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   53.46%   53.18%   -0.28%     
==========================================
  Files         103      104       +1     
  Lines       17712    17812     +100     
  Branches    17712    17812     +100     
==========================================
+ Hits         9469     9474       +5     
- Misses       7674     7771      +97     
+ Partials      569      567       -2     
Files Coverage Δ
xlineapi/src/lib.rs 71.69% <ø> (ø)
xline-client/src/lib.rs 0.73% <0.00%> (ø)
xline-client/src/clients/cluster.rs 0.00% <0.00%> (ø)
xline-client/src/types/cluster.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themanforfree themanforfree added this to the v0.6.0 milestone Oct 7, 2023
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
@iGxnon iGxnon marked this pull request as ready for review October 11, 2023 06:58
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon iGxnon merged commit b9e4660 into xline-kv:master Oct 11, 2023
16 of 18 checks passed
@iGxnon iGxnon deleted the feat/cluster-client branch October 11, 2023 11:51
@Phoenix500526 Phoenix500526 added the enhancement New feature or request label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants