refactor: move command related data structures #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 63.36% 63.41% +0.04%
==========================================
Files 101 102 +1
Lines 18540 18540
Branches 18540 18540
==========================================
+ Hits 11748 11757 +9
+ Misses 6061 6051 -10
- Partials 731 732 +1 ☔ View full report in Codecov by Sentry. |
iGxnon
reviewed
Oct 10, 2023
bsbds
force-pushed
the
move-command
branch
3 times, most recently
from
8729d64 to
e3d2e2c
Compare
This commit simply do a move, it does not modify any existing code Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Some common data structures used by both
xlineandxline-clientneeded to be move toxlineapito simplify dependency relations.what changes does this pull request make?
This PR moves some data structures from
xlinetoxlineapiand makes necessary changes such as visibility and module path, it does not modify the original code.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)