Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bench client #496

Merged
merged 1 commit into from
Nov 14, 2023
Merged

refactor: bench client #496

merged 1 commit into from
Nov 14, 2023

Conversation

Kikkon
Copy link
Contributor

@Kikkon Kikkon commented Oct 28, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    slove Refactor BenchClient's implementation #486
  • what changes does this pull request make?
    refactored the internal implementation of the beanch client."
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

@Kikkon Kikkon marked this pull request as ready for review October 28, 2023 12:30
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the code and make it pass the Clippy ci process.

@themanforfree
Copy link
Collaborator

Looks like you're referencing the wrong issue number, please update it.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify your code to make it pass the clippy ci process. You can run cargo clippy --all-targets --all-features -- -D warnings in your local code.

benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
@Kikkon Kikkon force-pushed the bench_client branch 3 times, most recently from 8b9a74f to 37938b8 Compare November 6, 2023 14:04
@Phoenix500526 Phoenix500526 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the last commit message and make it meet the requirement of "Conventional Commits". FYI: https://github.com/xline-kv/Xline/blob/master/CONTRIBUTING.md#commit-message-guidelines

benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
@Kikkon Kikkon force-pushed the bench_client branch 2 times, most recently from 01a4a4e to 240d775 Compare November 8, 2023 02:32
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
@Kikkon Kikkon force-pushed the bench_client branch 2 times, most recently from 02bf13f to d363638 Compare November 12, 2023 14:59
@Kikkon Kikkon requested a review from Phoenix500526 November 12, 2023 15:01
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
benchmark/src/bench_client.rs Outdated Show resolved Hide resolved
@Phoenix500526
Copy link
Collaborator

During the CI process of this PR, the test case test_range_redirect panicked. I think it's a bug and not introduced by this PR. Could you please help to create a related issue to report this bug to the Xline community?

Signed-off-by: kikkon <nian920@outlook.com>
@xline-kv xline-kv deleted a comment from codecov bot Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (84c685a) 54.12% compared to head (0c25650) 63.55%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   54.12%   63.55%   +9.43%     
==========================================
  Files         101      101              
  Lines       18287    18333      +46     
  Branches    18287    18333      +46     
==========================================
+ Hits         9898    11652    +1754     
+ Misses       7804     5956    -1848     
- Partials      585      725     +140     
Files Coverage Δ
benchmark/src/bench_client.rs 67.74% <75.80%> (+67.74%) ⬆️

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7951bcb into xline-kv:master Nov 14, 2023
18 checks passed
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
@Phoenix500526 Phoenix500526 added the Improvement Refactor or optimization, including process, performance or something like that label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Refactor or optimization, including process, performance or something like that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor BenchClient's implementation
4 participants