-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bench client #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the code and make it pass the Clippy ci process.
Looks like you're referencing the wrong issue number, please update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify your code to make it pass the clippy ci process. You can run cargo clippy --all-targets --all-features -- -D warnings
in your local code.
8b9a74f
to
37938b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the last commit message and make it meet the requirement of "Conventional Commits". FYI: https://github.com/xline-kv/Xline/blob/master/CONTRIBUTING.md#commit-message-guidelines
01a4a4e
to
240d775
Compare
02bf13f
to
d363638
Compare
During the CI process of this PR, the test case |
Signed-off-by: kikkon <nian920@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 54.12% 63.55% +9.43%
==========================================
Files 101 101
Lines 18287 18333 +46
Branches 18287 18333 +46
==========================================
+ Hits 9898 11652 +1754
+ Misses 7804 5956 -1848
- Partials 585 725 +140
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
slove Refactor BenchClient's implementation #486
refactored the internal implementation of the beanch client."
no