Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix xline_update_node test and update comments #540

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:
#531

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    fix xline_update_node test
  • what changes does this pull request make?
    update node to an available address.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

@themanforfree themanforfree linked an issue Nov 22, 2023 that may be closed by this pull request
1 task
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8fb8a49) 63.42% compared to head (917f173) 63.41%.

Files Patch % Lines
curp/src/client.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   63.42%   63.41%   -0.01%     
==========================================
  Files         101      101              
  Lines       18541    18542       +1     
  Branches    18541    18542       +1     
==========================================
- Hits        11760    11759       -1     
- Misses       6048     6051       +3     
+ Partials      733      732       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iGxnon
iGxnon previously approved these changes Nov 22, 2023
Copy link
Contributor

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bsbds
bsbds previously approved these changes Nov 22, 2023
Signed-off-by: themanforfree <themanforfree@gmail.com>
@themanforfree themanforfree dismissed stale reviews from bsbds and iGxnon via 917f173 November 23, 2023 06:45
@themanforfree themanforfree merged commit a4dee03 into xline-kv:master Nov 23, 2023
16 of 18 checks passed
@themanforfree themanforfree deleted the fix/xline_update_node branch November 23, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: xline_update_node test case panic.
4 participants