-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch refactor-v0.7.0-new
#962
Conversation
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> chore: add reminder of a revision issue Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
refactor: remove cmd worker and mpmc channel from task manager Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> refactor: cmd trait Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> WIP: fix rebase cmd worker refactor: change command execute from async to sync Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
refactor: curp server refactor: update auth wrapper with the new stream api refactor: log persistent refactor: add new tasks to task manager WIP: command execution chore: clippy task manager chore: clippy client tests mock client chore: client retry chore: clippy curp error pattern match chore: clippy client tests Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> refactor: implement ResponseSender and ResponseReceiver chore: clippy response receiver Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> chore: remove log persistent task from task manager Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> fix: return immediately when receiving an error on propose Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> refactor: command execution logic Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> chore: fix clippy Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> fix: use propose id for read only cmds Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Request::set_timeout only works on the server side, if the server is not ready, the client may wait indefinitely Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
…tonic doesn't support it Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> fix: test ce Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
This check is not necessary, the urls are allowed to be empty before publish Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Because client id may change during retry, the propose id generation must be called for each retry Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
It seems sync wait on a event listener will potentialy cause a deadlock, we will address this in the future. Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
60bd0d4
to
97f6232
Compare
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
97f6232
to
1157cbd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 75.55% 75.19% -0.37%
==========================================
Files 180 189 +9
Lines 26938 28376 +1438
Branches 26938 28376 +1438
==========================================
+ Hits 20353 21337 +984
- Misses 5366 5750 +384
- Partials 1219 1289 +70 ☔ View full report in Codecov by Sentry. |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bsbds Convert your pr to draft since CI failed |
74467e2
to
0079e9c
Compare
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
0079e9c
to
6fa7400
Compare
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
6fa7400
to
5843ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge branch
refactor-v0.7.0-new
into master.Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)