Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reimplement curp client state #981

Closed

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Sep 3, 2024

Depends-On: #972

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

github-actions bot commented Oct 4, 2024

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the Stale label Oct 4, 2024
@bsbds bsbds mentioned this pull request Oct 9, 2024
@bsbds bsbds force-pushed the impl-curp-client-state branch from 19a52f4 to d3ba151 Compare October 9, 2024 01:16
@bsbds bsbds removed the Stale label Oct 9, 2024
@bsbds bsbds changed the base branch from master to refactor-curp-client October 9, 2024 09:39
Copy link

github-actions bot commented Nov 9, 2024

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the Stale label Nov 9, 2024
Copy link

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Nov 23, 2024
@bsbds bsbds reopened this Dec 2, 2024
@github-actions github-actions bot removed the Stale label Dec 3, 2024
@bsbds bsbds force-pushed the impl-curp-client-state branch from d3ba151 to a88d7a3 Compare December 3, 2024 07:34
@bsbds bsbds marked this pull request as ready for review December 3, 2024 07:34
Copy link

mergify bot commented Dec 3, 2024

@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml.

@mergify mergify bot requested a review from a team December 3, 2024 07:34
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
@bsbds bsbds force-pushed the impl-curp-client-state branch from a88d7a3 to c32b1ee Compare December 3, 2024 07:54
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (refactor-curp-client@71479a4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/curp/src/client/unary/state.rs 0.00% 20 Missing ⚠️
crates/curp/src/client/unary/config.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             refactor-curp-client     #981   +/-   ##
=======================================================
  Coverage                        ?   75.09%           
=======================================================
  Files                           ?      194           
  Lines                           ?    28628           
  Branches                        ?    28628           
=======================================================
  Hits                            ?    21497           
  Misses                          ?     5830           
  Partials                        ?     1301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant