[Refactor]: Retry client #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
LingKa28
added
the
Improvement
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 83.66% 83.57% -0.09%
==========================================
Files 18 18
Lines 1120 1120
Branches 84 84
==========================================
- Hits 937 936 -1
- Misses 156 157 +1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
LingKa28
force-pushed
the
refactor/retry-client
branch
from
9915676 to
9dcefe1
Compare
Signed-off-by: LingKa <cnfty786@gmail.com>
Signed-off-by: LingKa <cnfty786@gmail.com>
Signed-off-by: LingKa <cnfty786@gmail.com>
LingKa28
force-pushed
the
refactor/retry-client
branch
from
9dcefe1 to
53e57c3
Compare
iGxnon
reviewed
Mar 4, 2024
| @@ -216,6 +216,12 @@ async def fetch_cluster(self) -> FetchClusterResponse: | |||
| raise curp_err | |||
|
|
|||
| raise CurpError(_CurpError(RpcTransport=Empty())) | |||
|
|
|||
| def update_leader(self, leader_id: int | None, term: int) -> bool: | |||
There was a problem hiding this comment.
It seems that there is no lock protects check_and_update_leader.
There was a problem hiding this comment.
You may add an additional lock here to protect update_leader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)