fixes #218 by filtering sheet scoped names to named ranges for now #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n line with workbook scoped named ranges)
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
app/static/js/core/xlwingsjs/xlwings.js:360
- Ensure that namedItem.type is a valid property and that 'Range' is the correct value to filter by. If namedItem.type can be undefined, this condition might cause issues.
if (namedItem.type === "Range") {
app/static/js/core/xlwingsjs/xlwings.js:363
- Ensure that namedItem.getRange() always returns a valid object and that the load method calls are correct.
sheet: namedItem.getRange().worksheet.load("position"),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is in line with workbook scoped named ranges