-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update curl version list #104
Conversation
Merged with base branch. I'm wondering, should we disable test building? It doesn't seem really useful here (and is causing compilation issues with msvc and libcurl 7.64.0 because of an empty file) |
If it is a test build of libcurl itself, as long as cmakelist provides an option to disable them, we usually agree to disable them |
Yes it is, I'll make a separate PR for this. |
Following #101 I made the changes, except for two things:
Sorry about all the failing checks from the previous commit. |
No, xmake.lua of each package is completely isolated and it will also not affect on_install. |
Oh alrighty then. Another thing I didn't know. I'm making the changes as requested. |
Well this time I don't understand why it's failing, maybe it's not including the good versions.lua file? Should I use |
Oh, it's the first time I use include in package/xmake.lua, I need to look at it, please wait. : ( |
No problem, I'm trying some stuff on my side too. It seems the versions.lua file is not executed (adding |
You should write: includes(path.join(os.scriptdir(), "versions.lua")) |
Perfect! Thank you. |
ci fails, maybe we need add if is_plat("macosx") then
-- ...
table.insert(configs, "--without-zstd")
end |
Should I make another PR? |
No need for a new one, please modify it directly on the current pr |
Thank you very much for your contribution. 👍 |
No problem 😸 I think you can expect a few more soon! |
See #101