Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add llfio package #1631

Merged
merged 21 commits into from
Nov 28, 2022
Merged

Add llfio package #1631

merged 21 commits into from
Nov 28, 2022

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Nov 15, 2022

No description provided.

@Arthapz Arthapz marked this pull request as draft November 16, 2022 16:35
waruqi
waruqi reviewed Nov 17, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 17, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 17, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 17, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 17, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
@waruqi
Copy link
Member

waruqi commented Nov 22, 2022

#1645

@Arthapz
Copy link
Member Author

Arthapz commented Nov 22, 2022

i was working on this :D juste taking my time because of some works

This was referenced Nov 22, 2022
Merged
Merged
@Arthapz
Copy link
Member Author

Arthapz commented Nov 23, 2022

ned14 cmake is horrible, i will convert llfio and the needed libraries to XMake

@Arthapz Arthapz mentioned this pull request Nov 23, 2022
Merged
waruqi
waruqi reviewed Nov 25, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 25, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
waruqi
waruqi reviewed Nov 25, 2022
View reviewed changes
packages/l/llfio/xmake.lua Outdated Show resolved Hide resolved
@waruqi
Copy link
Member

waruqi commented Nov 27, 2022

maybe we can disable android platform.

@Arthapz
Copy link
Member Author

Arthapz commented Nov 27, 2022

std::filesystem on android is supported only from ndk 22, but the CI use ndk 21 so the compilation doesn't work :/

@waruqi
Copy link
Member

waruqi commented Nov 27, 2022

std::filesystem on android is supported only from ndk 22, but the CI use ndk 21 so the compilation doesn't work :/

you can switch ndk to 22 on ci

@Arthapz
Copy link
Member Author

Arthapz commented Nov 27, 2022

how ?

@Arthapz
Copy link
Member Author

Arthapz commented Nov 27, 2022

\o/ it work

@Arthapz Arthapz marked this pull request as ready for review November 27, 2022 19:01
@waruqi
Copy link
Member

waruqi commented Nov 28, 2022

\o/ it work

Great,but it still has compile errors on freebsd.

@waruqi waruqi merged commit 4ff6b95 into xmake-io:dev Nov 28, 2022
@Arthapz Arthapz deleted the add-llfio branch April 1, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthapz @waruqi