Skip to content

Xmlto: FIx implicit int #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+2 −0
Open

Xmlto: FIx implicit int #8447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7396d5
fix implicit int
Oct 21, 2025
70017d5
Merge branch 'xmake-io:dev' into xmlto
Casinius Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/x/xmlto/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ package("xmlto")

on_install("macosx", "linux", function (package)
import("package.tools.autoconf")
io.replace("xmlif/xmlif.l",[[static ifsense;]],[[static int ifsense;]],{plain = true})
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The original code static ifsense; uses an implicit int declaration, which is not allowed by newer compilers. Explicitly declaring the variable as static int ifsense; resolves this issue.

Suggestion: Use explicit type declaration for variables.

io.replace("xmlif/xmlif.l",[[static ifsense;]],[[static int ifsense;]],{plain = true})

io.replace("xmlif/xmlif.l",[[main(int argc, char *argv[])]],[[int main(int argc, char *argv[])]],{plain = true})
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The original code main(int argc, char *argv[]) uses an implicit int return type, which is not allowed by newer compilers. Explicitly declaring the return type as int main(int argc, char *argv[]) resolves this issue.

Suggestion: Always specify the return type of the main function.

io.replace("xmlif/xmlif.l",[[main(int argc, char *argv[])]],[[int main(int argc, char *argv[])]],{plain = true})

local envs = autoconf.buildenvs(package)
local getopt = package:dep("util-linux"):fetch()
for _, dir in ipairs(getopt.linkdirs) do
Expand Down
Loading