Skip to content

Auto-update sqlgen to v0.3.0 #8463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update sqlgen to v0.3.0 #8463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/s/sqlgen/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("sqlgen")
add_urls("https://github.com/getml/sqlgen/archive/refs/tags/$(version).tar.gz",
"https://github.com/getml/sqlgen.git")

add_versions("v0.3.0", "f3a086e26a069f243265769831837d385986734458f52ed3aef06efddf03b3ac")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of version v0.3.0, a couple of related points in this file may need updates for correctness and maintainability:

  1. arm64 support with PostgreSQL: The on_check block (lines 36-40) currently prevents the use of this package on arm64 when PostgreSQL support is enabled. If this limitation is resolved in v0.3.0, the check should be updated to apply only to older versions to enable arm64 support for the new version. For example:

    on_check(function (package)
    if package:config("postgres") and package:version():lt("0.3.0") then
        assert(not package:is_arch("arm64"), "package(%s) does not support arm64 for versions < 0.3.0", package:name())
    end
end)

  2. Patch for version 0.2.0: A patch is applied specifically for version 0.2.0 on line 12. If this patch is also required for v0.3.0, the version constraint for add_patches should be updated (e.g., to "<0.4.0"). If the patch has been upstreamed and is no longer needed, no change is necessary.

Addressing these points will help ensure the new version is well-integrated and works correctly across all supported configurations.

add_versions("v0.2.0", "c093036ebdf2aaf1003b2d1623713b97106ed43b1d39dc3d4f38e381f371799e")

add_patches("0.2.0", "patches/0.2.0/cmake.patch", "e9819b9a8a2c8f8a5b6c553eac3bb10fc65856aa9af451f83e2dbf55ca6c66c0")
Expand Down
Loading