jsoncons: Update to v1.4.3

[Willaaaaaaa]

Resolves: #8542

Reference: https://android.googlesource.com/platform/bionic/+/bcfe3cf/libc/include/wchar.h#98

error message:

checkinfo: ...amdir/core/sandbox/modules/import/core/tool/compiler.lua:84: @programdir/modules/core/tools/gcc.lua:1047: /home/runner/.xmake/packages/j/jsoncons/v1.4.3/ff5b680837404209ad5e3882e5ad26ef/include/jsoncons/utility/read_number.hpp:842:15: error: use of undeclared identifier 'wcstod_l'; did you mean 'wcstold_l'?
        val = wcstod_l(s, &end, locale);
              ^
/home/runner/.xmake/packages/n/ndk/22.1/73bb5a0e065c4d8fa242705e2555420f/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/wchar.h:191:13: note: 'wcstold_l' declared here
long double wcstold_l(const wchar_t* __s, wchar_t** __end_ptr, locale_t __l) __INTRODUCED_IN(21);
            ^
1 error generated.

[gemini-code-assist]

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the jsoncons library to its v1.4.3 release. Crucially, it also introduces a specific check for Android NDK environments, enforcing a minimum API level of 28. This change directly addresses a build error encountered with wcstod_l on Android, ensuring proper compilation and compatibility for the updated library across different platforms.

Highlights

• Library Update: The jsoncons library has been updated to version v1.4.3.
• Android NDK Compatibility: A new check has been added to ensure that Android builds for jsoncons require an NDK API level of 28 or higher to resolve a wcstod_l undeclared identifier error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the jsoncons package to version v1.4.3, which resolves a build failure on Android. To support this, a check has been added to ensure the Android NDK API level is 28 or higher, as required by the updated library. The changes are logical and well-implemented. I have one suggestion to make the NDK version check more robust to prevent potential runtime errors in the build script.